Port Python 2 API to Python 3 #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobbaungard
approved these changes
Dec 2, 2021
I messed around a bit and created one such version that works with 2/3. I'll update the PR.. |
Re-factor the Python 2 Livestatus library to work under both 2/3: * Replace some py2-only idioms and fix some errors like trying to access `.keys()` on a list. * Let all literal strings be unicode on both py2/3 (`from __future__ import unicode_literals`). This way, the modules code internally works with unicode stings (`unicode` on py2, `str` on py3) and converts to byte strings when writing to socket. * API methods take either unicode strings or byte (`str` on py2, `bytes` on py3) as input. Signed-off-by: Aksel Sjögren <asjogren@itrsgroup.com>
|
Nice, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy livestatus Python API from
api/pythontoapi/python3and makenecessary changes to run under Python 3 (somewhat tested on 3.6).
The original GPL'ed sources are from commit
e06cefe.
Signed-off-by: Aksel Sjögren asjogren@itrsgroup.com