Add option to set the working directory for degoss #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naftulikay
requested changes
Oct 8, 2019
There was a problem hiding this comment.
Looks great, can you instead move this variable to degoss_base_workdir or degoss_workdir_base? I want it to be a little bit clearer that it sets the base directory and generates a temporary directory within that base directory.
Thank you for your contribution! 👏
|
I have updated it to |
naftulikay
approved these changes
Oct 10, 2019
|
Released in v3.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If SELinux is enabled on the remote host, ansible cannot execute the workdir files in
/tmp.I have added an option to set the workdir that degoss puts the files in to mitigate the issue.