Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Australia - Easter Sunday missing for some states #608

Closed
pdegenhardt opened this issue Mar 7, 2024 · 6 comments
Closed

Australia - Easter Sunday missing for some states #608

pdegenhardt opened this issue Mar 7, 2024 · 6 comments
Labels

Comments

@pdegenhardt
Copy link

Affected country

Australia

Affected public holiday

Easter Sunday

Source of the information

https://www.qld.gov.au/recreation/travel/holidays/public

More information

All states have nominated Easter Sunday as a public holiday. E.g. Queensland link shown above.

The API incorrectly provides the date only for: ACT, NSW, VIC and WA.

It is currently national, so the simplest fix would seem to be to simply remove the 'Counties' specification.

@pdegenhardt pdegenhardt added the bug label Mar 7, 2024
@tinohager
Copy link
Member

hat would mean that from 2017 the holiday should apply to the whole of australia

private HolidaySpecification EasterSunday(int year)
{
var holidaySpecification = this._catholicProvider.EasterSunday("Easter Sunday", year);
var counties = new [] { "AU-ACT", "AU-NSW", "AU-VIC" };
if (year >= 2022)
{
counties = ["AU-ACT", "AU-NSW", "AU-VIC", "AU-WA"];
}
holidaySpecification.SubdivisionCodes = counties;
return holidaySpecification;
}

@tinohager
Copy link
Member

tinohager commented Mar 13, 2024

I have check this source -> https://www.fairwork.gov.au/employment-conditions/public-holidays

ACT NSW NT QLD SA TAS VIC WA
2021 - - - -
2022 - - -
2023 - -
2024 -
2025 -

It looks in Tasmania Easter Sunday is not a public holiday.
Addition: with the waybackMachine i add the info for 2022 and 2021

@pdegenhardt
Copy link
Author

Wow! I actually live in Tasmania and I had no idea. How bizarre!

@tinohager
Copy link
Member

Hi, i have push a pull request can you check it please

@pdegenhardt
Copy link
Author

Looks good to me. Thanks.

tinohager added a commit that referenced this issue Mar 19, 2024
@tinohager
Copy link
Member

tinohager commented Mar 19, 2024

i have published a new version

BelmoMusta added a commit to BelmoMusta/Nager.Date that referenced this issue Mar 20, 2024
* Morocco - Add Amazigh new year (nager#620)

Starting from 2024

* cleanup code

* cleanup code

* Optimize Unit Tests

* Australia - Fix Easter Sunday (nager#621)

nager#608

---------

Co-authored-by: Tino Hager <tino.hager@nager.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants