Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assumed Identity endpoint in Lowkey Vault #960

Closed
alpapad01 opened this issue Apr 23, 2024 · 3 comments
Closed

Assumed Identity endpoint in Lowkey Vault #960

alpapad01 opened this issue Apr 23, 2024 · 3 comments
Assignees
@nagyesta
Labels
community requested Issues requested by our community enhancement New feature or request released Released, waiting for feedback

Comments

@alpapad01
Copy link

Fist, great project, solves a tone of problems. A big thank-you!!

Is your feature request related to a problem? Please describe.

To test an application which uses Azure vault, without changing configurations (and possibly code?), one needs to have the nagyesta/assumed-identity:1.2.16 docker image running next to lowkey-vault.

Describe the solution you'd like

It would be great to expose the single GET endpoint of assumed-identity from lowkey-vault itself. This way, there is one container less to run (less resources).

I have tested such a solution and it works.
@alpapad01 alpapad01 added the enhancement New feature or request label Apr 23, 2024
@nagyesta
Copy link
Owner

Hi @alpapad01 ,
Thank you for using Lowkey Vault! Also, thank you for the feedback and the nice idea! I agree, it could work. I will look into it and come back to you with some updates...

@nagyesta nagyesta self-assigned this Apr 23, 2024
@nagyesta nagyesta moved this from Ideas to Prioritized backlog in Lowkey Vault Roadmap Apr 23, 2024
@nagyesta nagyesta added the community requested Issues requested by our community label Apr 23, 2024
@nagyesta nagyesta moved this from Prioritized backlog to In progress in Lowkey Vault Roadmap Apr 26, 2024
nagyesta added a commit that referenced this issue Apr 26, 2024
@nagyesta
Assumed Identity endpoint in Lowkey Vault
bae8752 
- Adds configuration to listen to the 8080 HTTP port for token requests
- Adds new ManagedIdentityTokenController to handle token requests
- Adds filter to enforce functional separation between the 8080 and 8443 ports
- Extends Testcontainers support with token endpoint related configuration
- Adds new tests
- Updates documentation

Updates #960
{minor}

Signed-off-by: Esta Nagy <nagyesta@gmail.com>
@nagyesta nagyesta mentioned this issue Apr 26, 2024
Merged
5 tasks
@nagyesta nagyesta changed the title Assumed Identity endpoint in lowkey-vaulut Assumed Identity endpoint in Lowkey Vault Apr 26, 2024
nagyesta added a commit that referenced this issue Apr 26, 2024
@nagyesta
Assumed Identity endpoint in Lowkey Vault (#972)
de867f8 
- Adds configuration to listen to the 8080 HTTP port for token requests
- Adds new ManagedIdentityTokenController to handle token requests
- Adds filter to enforce functional separation between the 8080 and 8443 ports
- Extends Testcontainers support with token endpoint related configuration
- Adds new tests
- Updates documentation

Updates #960
{minor}

Signed-off-by: Esta Nagy <nagyesta@gmail.com>
@nagyesta
Copy link
Owner

Hi @alpapad01 ,
this was implemented and is being released in v2.4.2.

I think it should be working, but please let me know whether it is what you had in mind!

Thank you in advance!

@nagyesta nagyesta added the released Released, waiting for feedback label Apr 27, 2024
@nagyesta nagyesta mentioned this issue Apr 27, 2024
Merged
4 tasks
@nagyesta
Copy link
Owner

nagyesta commented May 7, 2024

Hi @alpapad01 ,
I assume it must have worked, so I am closing the ticket. Please feel free to reopen (or open a new one) in case you see further problems!

Thank you and best of luck!

@nagyesta nagyesta closed this as completed May 7, 2024
@github-project-automation github-project-automation bot moved this from In progress to Released in Lowkey Vault Roadmap May 7, 2024
@Xor-el Xor-el mentioned this issue Jan 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nagyesta nagyesta

Labels
community requested Issues requested by our community enhancement New feature or request released Released, waiting for feedback
Projects
Lowkey Vault Roadmap
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nagyesta @alpapad01