Skip to content
This repository has been archived by the owner on Mar 9, 2023. It is now read-only.

Integration breaks built-in KNX integration #50

Closed
marvin-w opened this issue Aug 11, 2022 · 6 comments
Closed

Integration breaks built-in KNX integration #50

marvin-w opened this issue Aug 11, 2022 · 6 comments

Comments

@marvin-w
Copy link

Hello,

we recently had a bug report in HA core (home-assistant/core#76604) mentioning that a very old xknx version is used to run the KNX integration. After some analysis the issue creator found out that this custom integration is using xknx==0.9.4, which is from 3 years ago as a pinned dependency.

Can you please update to the latest version of xknx or even better - get rid of it altogether.

@nagyrobi
Copy link
Owner

You're more than welcome to suggest a patch in a PR...

@nagyrobi
Copy link
Owner

That part was employed before I forked from @davidramosweb...

@farmio
Copy link

farmio commented Aug 11, 2022

You may just copy this file (or an older version if you prefer) to this repo, remove the requirement and import from . instead of form xknx.devices.
https://github.com/XKNX/xknx/blob/main/xknx/devices/travelcalculator.py

@nagyrobi
Copy link
Owner

Thank you both for the issue sumbission and permission to use the code as copied.
Removed dependency in cd08511 and released a new version which can be upgraded to via HACS.

@marvin-w
Copy link
Author

Thank you for fixing it so fast :)

@nagyrobi
Copy link
Owner

Was easy with @farmio's suggestion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants