Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all deprecated APIs/features in prep for 1.7.0 release #195

Closed
12 tasks done
davewichers opened this issue Jul 9, 2022 · 1 comment
Closed
12 tasks done

Remove all deprecated APIs/features in prep for 1.7.0 release #195

davewichers opened this issue Jul 9, 2022 · 1 comment

Comments

@davewichers
Copy link
Collaborator

davewichers commented Jul 9, 2022 •
edited
Loading

Deprecated things to remove in 1.7.0 branch (including the ability to disable schema validation on AntiSamy policy files):

  • CssHandler(Policy, LinkedList<URI>, List<String>, ResourceBundle) constructor and any uses of it.
  • CssHandler(Policy, LinkedList<URI>, List<String>, String, ResourceBundle) constructor and any uses of it.
  • Entire class ASXHTMLSerializer and any uses of it.
    • Not sure how this is invoked/used. There might be some AntiSamy policy elements related to this that we have to retire too?
  • InternalPolicy.isUseXhtml() method and any uses of it.
  • Remove or change all test cases related to the above changes, and Policy as well, so they all pass.

In Policy.java:

  • Remove public static final String USE_XHTML = "useXHTML"
  • Remove public static boolean getSchemaValidation()
  • Remove public static void setSchemaValidation()

Other things to be done as part of 1.7.0 release:

  • enable the directive "noopenerAndNoreferrerAnchors" by default.
  • Update README to reflect all API/Feature changes, with guidance on how to port to new APIs.

Reformatting prior to 1.7.0 release:
davewichers added a commit that referenced this issue Jul 9, 2022
@davewichers
Remove a deprecated CssHandler constructor to address 1 task in issue #…
8739792 
…195. Most of the deprecated items listed in this issue have already been addressed by @spassarop.
@davewichers
Copy link
Collaborator Author

All addressed, merged into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davewichers