Fix IllegalStateException on rgb percentage values #547
Conversation
… percentage rgb values
|
@spassarop - Can you look at this when you get a chance and let me know what you think? Is it a legit problem? Does the test case verify the program right? And is the fix right? |
|
@jonah1und1 I waited to be on my computer again and I can see the comments of a pending review I opened yesterday. I even tagged you in one. Do you see anything in this PR view? If you are logged in you should. |
|
@spassarop Sadly, I am still unable to see your comments. |
|
I looked yesterday and couldn't find them either.
…On Fri, Jan 24, 2025, 5:33 AM jonah1und1 ***@***.***> wrote:
@spassarop <https://github.com/spassarop> Sadly, I am still unable to see
your comments.
—
Reply to this email directly, view it on GitHub
<#547 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAO6PG6SIVC26ZNFU6VAK6D2MIJH3AVCNFSM6AAAAABVQJS6UWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJSGE4TONJQG4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
| * @return color value as int | ||
| */ | ||
| private int getColorIntValue(LexicalUnit param) { | ||
| if (param.getLexicalUnitType() == LexicalUnit.SAC_PERCENTAGE) { |
There was a problem hiding this comment.
@jonah1und1 knowing we are dealing with building a string and it is possible to detect if we are handling a percentage, don't you think it would be most suitable and reliable in terms of matching the original input to reconstruct the percentage as a string? I know this affects your proposed method signature returning an int, but we always try to be as much equal as possible to the input if we can.
There was a problem hiding this comment.
Makes sense, I refactored the method.
|
I think I had to submit the review. Can you see it now? |
Yes, I can. Thank you. |
…f converting them to int
|
@spassarop Thank you for your review! |
Possible fix for #546.