Improve onsiteURL regex to prevent jumping out the origin domain #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
spassarop
commented
Nov 12, 2020
spassarop
commented
- Fixes the default onsiteURL regex is not safe, if the url starts with '//', the url can jump out of the origin domain #48.
- Updated on every policy file.
- It actually prevents jumping out the origin domain. - Updated on every policy.
|
Looks good. Merging now and I'll test it after the merge to make sure. Your new test fails when I revert the policy change, and passes with the change. So looks good to me. @nahsra - any thoughts on this change? Look good to you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.