Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ver3.3.0 #18

Merged
merged 20 commits into from
Mar 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
matrix:
os:
- windows-latest
- macos-latest
- macos-14
python-ver:
- 3.11
steps:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,16 @@ jobs:
fail-fast: false
matrix:
python-ver: [3.11]
# only build for Windows. Because Mac needs software notarization but I don't have $99 for it.
os: [windows-latest, macos-latest, macos-latest-xlarge]
# Intel mac for macos-13, M1/2 mac for macos-14
os: [windows-latest, macos-13, macos-14]
include:
- os: windows-latest
build_cmd: build_win.bat
zip_name: PlaySK-PianoRoll-Reader-Win.x64.zip
- os: macos-latest
- os: macos-13
build_cmd: bash build_mac.sh
zip_name: PlaySK-PianoRoll-Reader-Mac.x64.zip
- os: macos-latest-xlarge
- os: macos-14
build_cmd: bash build_mac.sh
zip_name: PlaySK-PianoRoll-Reader-Mac.ARM.zip

Expand Down Expand Up @@ -95,7 +95,7 @@ jobs:
pushd dist
brew install create-dmg
test -f PlaySK-Installer.dmg && rm PlaySK-Installer.dmg
create-dmg --volname "PlaySK Installer" --background ../docs/dmg-bg.tiff --window-pos 200 120 --window-size 800 500 --icon-size 100 --icon "PlaySK Piano Roll Reader.app" 100 100 --add-file "playsk_config" playsk_config 100 300 --hide-extension "PlaySK Piano Roll Reader.app" --app-drop-link 600 200 "PlaySK-Installer.dmg" "PlaySK Piano Roll Reader.app"
create-dmg --volname "PlaySK Installer" --background ../assets/dmg-bg.tiff --window-pos 200 120 --window-size 800 500 --icon-size 100 --icon "PlaySK Piano Roll Reader.app" 100 100 --add-file "playsk_config" playsk_config 100 300 --hide-extension "PlaySK Piano Roll Reader.app" --app-drop-link 600 200 "PlaySK-Installer.dmg" "PlaySK Piano Roll Reader.app"
popd
mv dist/PlaySK-Installer.dmg "dist/How to use Mac.png" dist/3rd-party-license.txt .
zip -qr ${{ matrix.zip_name }} sample_scans/ PlaySK-Installer.dmg "How to use Mac.png" "3rd-party-license.txt"
Expand Down
362 changes: 362 additions & 0 deletions 3rd-party-license.txt

Large diffs are not rendered by default.

7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,22 @@
# PlaySK Piano Roll Reader Ver3.2
# PlaySK Piano Roll Reader Ver3.3

Optically reading a piano roll image, emulates expression and output midi signal in real-time.

![Overall System](./docs/Overall_System.webp)
![Overall System](./assets/Overall_System.webp)

The "virtual tracker bar" optically picks up roll holes then emulates note, pedal and expression.
Currently, 9 virtual tracker bars are available.
- Standard 88-note
- Ampico B
- Duo-Art
- Welte-Mignon Licensee
- Welte-Mignon T-98 (Green)
- Welte-Mignon T-100 (Red)
- Philipps Duca (no expression. experimental)
- Recordo version A / B
- Artecho

In the future, Ampico A, Welte T-98 will be supported.
In the future, Ampico A will be supported.

Support image formats are `.cis`, `.jpg`, `.tif`, `.png`, `.bmp`.

Expand Down
Binary file added assets/How to use Mac.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/How to use.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
File renamed without changes
File renamed without changes.
File renamed without changes
File renamed without changes.
File renamed without changes
2 changes: 1 addition & 1 deletion build_mac.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ pip-licenses --format=plain-vertical --with-license-file --no-license-path --out

# copy files
cp -p "3rd-party-license.txt" dist/
cp -p "docs/How to use Mac.png" dist/
cp -p "assets/How to use Mac.png" dist/
cp -pr src/playsk_config/ dist/playsk_config/
2 changes: 1 addition & 1 deletion build_mac.spec
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,5 @@ app = BUNDLE(
name='PlaySK Piano Roll Reader.app',
icon='src/playsk_config/PlaySK_icon.ico',
bundle_identifier=None,
version='3.2.0'
version='3.3.0'
)
2 changes: 1 addition & 1 deletion build_win.bat
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,5 @@ pip-licenses --format=plain-vertical --with-license-file --no-license-path --out

rem copy files
xcopy /i /y "3rd-party-license.txt" ".\dist\PlaySK Piano Roll Reader\"
xcopy /i /y ".\docs\How to use.png" ".\dist\PlaySK Piano Roll Reader\"
xcopy /i /y ".\assets\How to use.png" ".\dist\PlaySK Piano Roll Reader\"
xcopy /s /i /y ".\src\playsk_config\" ".\dist\PlaySK Piano Roll Reader\playsk_config\"
Binary file removed docs/How to use Mac.png
Binary file not shown.
Binary file removed docs/How to use.png
Binary file not shown.
2 changes: 1 addition & 1 deletion notarize_mac.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ xcrun stapler staple "PlaySK Piano Roll Reader.app"
# create dmg
echo "~~ create dmg ~~"
test -f PlaySK-Installer.dmg && rm PlaySK-Installer.dmg
create-dmg --volname "PlaySK Installer" --background ../docs/dmg-bg.tiff \
create-dmg --volname "PlaySK Installer" --background ../assets/dmg-bg.tiff \
--window-pos 200 120 --window-size 800 500 \
--icon-size 100 --icon "PlaySK Piano Roll Reader.app" 100 100 \
--add-file "playsk_config" playsk_config 100 300 \
Expand Down
134 changes: 133 additions & 1 deletion poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "PlaySK-Piano-Roll-Reader"
version = "3.2.0"
version = "3.3.0"
description = "Optically reading a piano roll image, emulates expression and output midi signal in real-time."
authors = ["nai-kon <fxtch686@yahoo.co.jp>"]
readme = "README.md"
Expand All @@ -14,6 +14,7 @@ opencv-python-headless = "^4.8.0.76"
numpy = "^1.26.0"
mido = "^1.3.0"
cython = "^3.0.2"
pydantic = "^2.6.4"

[tool.poetry.group.dev.dependencies]
pyinstaller = "6.1.0"
Expand Down
Loading