Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka as service #33

Merged
merged 16 commits into from
Mar 2, 2022
Merged

Kafka as service #33

merged 16 commits into from
Mar 2, 2022

Conversation

Kyrremann
Copy link
Contributor

Mangler å dokumentere endringen

This is to support other services, such as OpenSearch
@Kyrremann Kyrremann requested a review from mortenlj February 26, 2022 19:36
This was referenced Feb 26, 2022
Copy link
Contributor

@mortenlj mortenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser greit ut, med unntak av to micro-feil.

cmd/root/aiven/create_cmd.go Outdated Show resolved Hide resolved
@@ -1622,8 +1622,8 @@ rsc.io/quote/v3 v3.1.0/go.mod h1:yEA65RcK8LyAZtP9Kv3t0HmxON59tX3rD+tICJqUlj0=
rsc.io/sampler v1.3.0/go.mod h1:T1hPZKmBbMNahiBKFy5HrXp6adAjACjK9JXDnKaTXpA=
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.0.25/go.mod h1:Mlj9PNLmG9bZ6BHFwFKDo5afkpWyUISkb9Me0GnK66I=
sigs.k8s.io/controller-runtime v0.5.0/go.mod h1:REiJzC7Y00U+2YkMbT8wxgrsX5USpXKGhb2sCtAXiT8=
sigs.k8s.io/controller-runtime v0.11.1 h1:7YIHT2QnHJArj/dk9aUkYhfqfK5cIxPOX5gPECfdZLU=
sigs.k8s.io/controller-runtime v0.11.1/go.mod h1:KKwLiTooNGu+JmLZGn9Sl3Gjmfj66eMbCQznLP5zcqA=
sigs.k8s.io/controller-runtime v0.11.0 h1:DqO+c8mywcZLFJWILq4iktoECTyn30Bkj0CwgqMpZWQ=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hvorfor downgrade her?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Godt spørsmål, den kom med en go mod tidy 🤔

Copy link
Contributor

@mortenlj mortenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syns dette ser litt mer forståelig ut enn det som var fra før 👍

pkg/aiven/aiven.go Outdated Show resolved Hide resolved
pkg/config/kafka_environment.go Outdated Show resolved Hide resolved
@Kyrremann Kyrremann merged commit 968bf68 into master Mar 2, 2022
@Kyrremann Kyrremann deleted the kafka_as_service branch March 2, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants