use nais-team-app instead of srvnais PAT #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
more info: https://github.com/apps/nais-team-app i should have added the necessary secrets (`NAIS_APP_PRIVATE_KEY`, and `NAIS_APP_ID`), but it's probably smart to have a look at the [repository secrets](../settings/secrets/actions) and verify their existence before merging this. also, i removed PUSH_TOKEN from the goreleaser step. i couldn't find the env variable documented anywhere in the goreleaser project, and i want to eliminate the use of `SRVNAIS_REPO_PUSH_PAT`
|
Line 33 in 804b22e It is used to push to https://github.com/nais/homebrew-tap. |
mortenlj
requested changes
Oct 14, 2021
mortenlj
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more info: https://github.com/apps/nais-team-app
i should have added the necessary secrets (
NAIS_APP_PRIVATE_KEY, andNAIS_APP_ID), but it's probably smart to have a look at the repository secrets and verify their existence before merging this.also, i removed PUSH_TOKEN from the goreleaser step. i couldn't find the env variable documented anywhere in the goreleaser project, and i want to eliminate the use of
SRVNAIS_REPO_PUSH_PAT