Merge pull request #213 from nais/flip-indeterminate-click

Selecting an indeterminate checkbox checks all child items
nais · Feb 3, 2025 · cc8c19a · cc8c19a
2 parents ea1c3f7 + 2b9ed03
commit cc8c19a
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/.changeset/lemon-jeans-pull.md b/.changeset/lemon-jeans-pull.md
@@ -0,0 +1,5 @@
+---
+"@nais/ds-svelte-community": minor
+---
+
+Selecting an indeterminate checkbox checks all child items
diff --git a/packages/ds-svelte-community/src/lib/components/ActionMenu/ActionMenuCheckboxItem.svelte b/packages/ds-svelte-community/src/lib/components/ActionMenu/ActionMenuCheckboxItem.svelte
@@ -30,7 +30,7 @@
 	data-index="0"
 	style="user-select: none;"
 	onclick={() => {
-		checked = checked === "indeterminate" ? false : !checked;
+		checked = checked === "indeterminate" ? true : !checked;
 		onchange?.(checked);
 	}}
 >

diff --git a/packages/ds-svelte-community/src/routes/components/ActionMenu/+page.svelte b/packages/ds-svelte-community/src/routes/components/ActionMenu/+page.svelte
@@ -236,6 +236,13 @@
 							: Object.values(views).some(Boolean)
 								? "indeterminate"
 								: false}
+						onchange={(checked) => {
+							views = {
+								started: checked,
+								fnr: checked,
+								tags: checked,
+							};
+						}}
 					>
 						Select all
 					</ActionMenuCheckboxItem>