Allow Empty List of Dependencies / No Build Files (#163)

* allow empty dependencies

Signed-off-by: anderssonw <wandersson.98@gmail.com>

* log on no build files

Signed-off-by: anderssonw <wandersson.98@gmail.com>

* slightly better message

Signed-off-by: anderssonw <wandersson.98@gmail.com>

* fix gradle test, no longer causes error

Signed-off-by: anderssonw <wandersson.98@gmail.com>

---------

Signed-off-by: anderssonw <wandersson.98@gmail.com>

pkg/build/jvm/gradle_test.go

@@ -1,11 +1,12 @@
 package jvm
 
 import (
-	"github.com/nais/salsa/pkg/build"
-	"github.com/nais/salsa/pkg/build/test"
 	"os"
 	"testing"
 
+	"github.com/nais/salsa/pkg/build"
+	"github.com/nais/salsa/pkg/build/test"
+
 	"github.com/stretchr/testify/assert"
 )
 
@@ -74,13 +75,6 @@ func TestBuildGradle(t *testing.T) {
 			Error:        true,
 			ErrorMessage: "could not find match, reading dir open testdata/whatever: no such file or directory",
 		},
-		{
-			Name:         "cant find supported build type",
-			BuildType:    BuildMaven(""),
-			WorkDir:      "testdata/jvm/gradle-kts",
-			Error:        true,
-			ErrorMessage: "no supported build files found: testdata/jvm/gradle-kts",
-		},
 		{
 			Name:      "support build.gradle file",
 			BuildType: BuildGradle(),

pkg/build/jvm/testdata/jvm/gradle-kts/.gradle/buildOutputCleanup/cache.properties

@@ -0,0 +1,2 @@
+#Thu Mar 02 13:32:47 CET 2023
+gradle.version=8.0.1

pkg/build/jvm/testdata/jvm/gradle/.gradle/buildOutputCleanup/cache.properties

@@ -1,2 +1,2 @@
-#Fri Oct 14 10:00:23 CEST 2022
-gradle.version=7.5.1
+#Thu Mar 02 13:32:48 CET 2023
+gradle.version=8.0.1

pkg/build/tool.go

@@ -2,8 +2,9 @@ package build
 
 import (
 	"fmt"
-	log "github.com/sirupsen/logrus"
 	"os"
+
+	log "github.com/sirupsen/logrus"
 )
 
 const (
@@ -38,7 +39,8 @@ func (t Tools) DetectDeps(workDir string) (*ArtifactDependencies, error) {
 			return deps, nil
 		}
 	}
-	return nil, fmt.Errorf(fmt.Sprintf("no supported build files found: %s", workDir))
+
+	return nil, nil
 }
 
 func match(t Tool, workDir string) (bool, string, error) {

pkg/commands/scan.go

@@ -4,6 +4,8 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
+	"os"
+
 	"github.com/nais/salsa/pkg/build"
 	"github.com/nais/salsa/pkg/build/golang"
 	"github.com/nais/salsa/pkg/build/jvm"
@@ -15,7 +17,6 @@ import (
 	"github.com/nais/salsa/pkg/vcs"
 	log "github.com/sirupsen/logrus"
 	"github.com/spf13/cobra"
-	"os"
 )
 
 var (
@@ -55,7 +56,12 @@ var scanCmd = &cobra.Command{
 			if err != nil {
 				return fmt.Errorf("detecting dependecies: %v", err)
 			}
-			deps = generatedDeps
+
+			if generatedDeps != nil {
+				deps = generatedDeps
+			} else {
+				log.Infof("no supported build files found for directory: %s, proceeding", workDir)
+			}
 		}
 
 		contextEnvironment, err := vcs.ResolveBuildContext(&buildContext, &runnerContext, &envContext)