feat: instrument critical methods in token/token exchange

Co-authored-by: Kim Tore Jensen <kimtjen@gmail.com>
nais · Nov 18, 2024 · 7b718e7 · 7b718e7
1 parent 0dad802
commit 7b718e7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/identity_provider.rs b/src/identity_provider.rs
@@ -13,6 +13,7 @@ use std::cmp::PartialEq;
 use std::collections::HashMap;
 use std::fmt::{Display, Formatter};
 use std::marker::PhantomData;
+use tracing::instrument;
 use utoipa::ToSchema;
 
 /// RFC 6749 token response from section 5.1.
@@ -301,6 +302,7 @@ where
         })
     }
 
+    #[instrument(skip_all)]
     fn create_assertion(&self, target: String) -> Option<String> {
         let assertion = A::new(self.token_endpoint.as_ref()?.clone(), self.client_id.clone(), target);
         serialize(assertion, self.client_assertion_header.as_ref()?, self.private_jwk.as_ref()?).ok()
@@ -338,6 +340,7 @@ where
         self.upstream_jwks.validate(&token).await.map(IntrospectResponse::new).unwrap_or_else(IntrospectResponse::new_invalid)
     }
 
+    #[instrument(skip_all)]
     async fn get_token_with_config(&self, config: TokenRequestBuilderParams) -> Result<TokenResponse, ApiError> {
         let params = R::token_request(config).ok_or(ApiError::Sign)?;
 

diff --git a/src/tracing.rs b/src/tracing.rs
@@ -1,4 +1,3 @@
-use log::info;
 use opentelemetry::trace::TracerProvider;
 use opentelemetry::{global, KeyValue};
 use opentelemetry_sdk::metrics::reader::DefaultTemporalitySelector;
@@ -9,7 +8,7 @@ use opentelemetry_semantic_conventions::{
     attribute::{DEPLOYMENT_ENVIRONMENT_NAME, SERVICE_NAME, SERVICE_VERSION},
     SCHEMA_URL,
 };
-use tracing::{instrument, span, Level};
+use tracing::{Level};
 use tracing_opentelemetry::{MetricsLayer, OpenTelemetryLayer};
 use tracing_subscriber::layer::SubscriberExt;
 use tracing_subscriber::util::SubscriberInitExt;