Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ktor): replace deprecated micrometer #560

Closed
wants to merge 2 commits into from
Closed

fix(ktor): replace deprecated micrometer #560

wants to merge 2 commits into from

Conversation

ybelMekk
Copy link
Contributor

@ybelMekk ybelMekk commented Dec 5, 2024

No description provided.

@ybelMekk ybelMekk requested a review from tronghn December 5, 2024 11:32
tronghn
tronghn approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@tronghn tronghn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should double check that the metrics-endpoint still works 😄 - I've previously seen some issues with the API changes here for micrometer and prometheus

@ybelMekk
Copy link
Contributor Author

ybelMekk commented Dec 5, 2024

You should double check that the metrics-endpoint still works 😄 - I've previously seen some issues with the API changes here for micrometer and prometheus

i will 😄

@ybelMekk
Copy link
Contributor Author

ybelMekk commented Dec 6, 2024

ok tried it out, a lot, and all i tried did not generate jvm and/or http metrics, only custome, so Im closing this for now, no stress.

@ybelMekk ybelMekk closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tronghn tronghn tronghn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ybelMekk @tronghn