Wait for rollout #260
Open
Wait for rollout #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starefossen
force-pushed
the
deploy-rollout-wait
branch
from
1c33eff
to
db4c23b
Compare
Reasonable-Solutions
approved these changes
Jan 2, 2024
| if err != nil { | ||
| return ctrl.Result{}, err | ||
| statusErr := r.updateStatusConnectionSuccess(ctx, unleash, stats) | ||
| if statusErr != nil { |
There was a problem hiding this comment.
if statusErr := .... ; statusErr != nil {...}
?
That refactor happend on line 300 so maybe it applies here to?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for rollout to complete before checking connection to Unleash. This prevents false positives when Unleash CRD is reporting success due to it checking the old replica.
Close #193