Adding captionBackgroundView #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the great PR! I will review it today or tomorrow. |
|
@nakajijapan OK, thanks! |
nakajijapan
reviewed
Feb 16, 2018
| lazy var captionBackgroundView: UIView = { | ||
| var captionBackgroundView = UIView() | ||
| if let captionHeight = captionHeight { | ||
| var y = view.bounds.height - captionHeight - 32.0 |
There was a problem hiding this comment.
I don't know what 32.0 is the value for.
Could you change the magic number to the variable?
There was a problem hiding this comment.
It's the padding of 32 below the caption label: Line 324
I will make it a constant and put a comment above the constant declaration to make it more clear!
nakajijapan
reviewed
Feb 16, 2018
nakajijapan
approved these changes
Feb 16, 2018
|
🆗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
目的 Purpose
キャプションを表示する機能はあるのですが、画面によっては見えにくくなったりしますので、
半透明なバックラウンドビューを見せたいです。
There's a feature for showing captions, but it's difficult to see depending on the screen,
so I would like to show a translucent background view.
実装内容
今後PRを考えている要素 Areas of consideration for future PRs
More customization options for caption text (shadow, etc)
Some refactoring with the animations
Some additional documentation