Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller-runtime: update README.md #280

Merged

Conversation

nakamasato
Copy link
Owner

@nakamasato nakamasato commented Sep 8, 2023

Changes in controller-runtime@v0.15.0

-       kindWithCacheMysqlUser := source.NewKindWithCache(mysqluser, cache)
-       kindWithCacheMysql := source.NewKindWithCache(mysql, cache)
-       kindWithCachesecret := source.NewKindWithCache(secret, cache)
+       kindWithCacheMysqlUser := source.Kind(cache, mysqluser)
+       kindWithCacheMysql := source.Kind(cache, mysql)
+       kindWithCachesecret := source.Kind(cache, secret)

Changes in controller-runtime@v0.16.0

import (
+ metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
)
- MetricsBindAddress: metricsAddr
+ Metrics: metricsserver.Options{BindAddress: metricsAddr},

@nakamasato nakamasato changed the base branch from main to renovate/sigs.k8s.io-controller-runtime-0.x September 9, 2023 00:14
@nakamasato nakamasato marked this pull request as ready for review September 9, 2023 00:18
@nakamasato nakamasato merged commit f4f91c4 into renovate/sigs.k8s.io-controller-runtime-0.x Sep 9, 2023
2 checks passed
@nakamasato nakamasato deleted the nakamasato-patch-1 branch September 9, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant