Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use mysql.Config.FormatDSN #188

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

nakamasato
Copy link
Owner

Close #186

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #188 (c1b3a55) into main (fdf9006) will increase coverage by 0.39%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
+ Coverage   65.50%   65.90%   +0.39%     
==========================================
  Files           6        6              
  Lines         516      522       +6     
==========================================
+ Hits          338      344       +6     
  Misses        137      137              
  Partials       41       41              
Impacted Files Coverage Δ
controllers/mysql_controller.go 61.40% <100.00%> (+5.84%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nakamasato nakamasato merged commit 39536e7 into main Mar 31, 2023
@nakamasato nakamasato deleted the use-mysql-config-formatdsn branch March 31, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve dsn config
1 participant