Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bug of MySQL.Status.DBCount #202

Merged
merged 12 commits into from
Apr 9, 2023
Merged

fix: fix bug of MySQL.Status.DBCount #202

merged 12 commits into from
Apr 9, 2023

Conversation

nakamasato
Copy link
Owner

@nakamasato nakamasato commented Apr 8, 2023

Close #197

Update Status.DBCount when referencedDBNum is different from Status.DBCount

@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Merging #202 (0672c7f) into main (e22ddd0) will decrease coverage by 1.94%.
The diff coverage is 57.53%.

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   65.29%   63.36%   -1.94%     
==========================================
  Files           6        6              
  Lines         559      595      +36     
==========================================
+ Hits          365      377      +12     
- Misses        150      168      +18     
- Partials       44       50       +6     
Impacted Files Coverage Δ
controllers/mysqluser_controller.go 66.83% <0.00%> (-7.40%) ⬇️
controllers/mysql_controller.go 52.86% <50.00%> (-2.11%) ⬇️
controllers/test_utils.go 74.00% <66.66%> (+0.82%) ⬆️
controllers/mysqldb_controller.go 47.36% <100.00%> (+4.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nakamasato nakamasato marked this pull request as ready for review April 9, 2023 04:15
@nakamasato nakamasato merged commit 259d4aa into main Apr 9, 2023
@nakamasato nakamasato deleted the fix-bug-of-dbcount branch April 9, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: DbCount is not updated
1 participant