Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e2e] Create mysql deployment in e2e instead of skaffold.yaml #77

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

nakamasato
Copy link
Owner

@nakamasato nakamasato commented Dec 7, 2021

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #77 (f318ff9) into main (3875e65) will increase coverage by 1.04%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   56.09%   57.14%   +1.04%     
==========================================
  Files           4        4              
  Lines         164      168       +4     
==========================================
+ Hits           92       96       +4     
- Misses         56       57       +1     
+ Partials       16       15       -1     
Impacted Files Coverage Δ
controllers/mysqluser_controller.go 66.96% <75.00%> (+0.29%) ⬆️
controllers/mysql_controller.go 25.53% <0.00%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3875e65...f318ff9. Read the comment docs.

@nakamasato nakamasato marked this pull request as ready for review December 7, 2021 00:41
@nakamasato nakamasato merged commit 4eb2c54 into main Dec 7, 2021
@nakamasato nakamasato deleted the use-mysql-created-in-e2e branch December 7, 2021 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant