Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade kubebuilder version to v3.10.0 #18

Merged
merged 296 commits into from
Jul 27, 2023
Merged

Conversation

nakamasato
Copy link
Owner

@nakamasato nakamasato commented Jul 26, 2023

Changes

  1. go.kubebuilder.io/v3 -> go.kubebuilder.io/v4
    1. [go/v3 vs go/v4](https://book.kubebuilder.io/migration/v3vsv4.html)
    2. Make go/v4-alpha and kustomize/v2-alpha to be stable and the default CLI scaffold kubernetes-sigs/kubebuilder#3117
    3. 📖 update multiversion tutorial to use go/v4 kubernetes-sigs/kubebuilder#3282
    4. Changes related to v4
      1. Standard Go Project Layout
        1. controllers -> internal/controller
        2. main.go -> cmd/main.go
      2. KUSTOMIZE_VERSION ?= v5.0.0 default version from 3.8.7 -> 5.0.0
        1. vars -> replacements in config/default/kustomization.yaml (https://kubectl.docs.kubernetes.io/references/kustomize/kustomization/replacements/) introduced in https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv4.1.3 to replace the vars feature
  2. k8s 1.26.1
  3. controller-runtime to 0.14.2
  4. export CONTROLLER_TOOLS_VERSION=v0.12.0 in .upgrade-version.sh

Errors

Error 1: parsing time "null" as "2006-01-02T15:04:05Z07:00": cannot parse "null" as "2006"

make install
test -s /Users/m.naka/repos/nakamasato/password-operator/bin/controller-gen && /Users/m.naka/repos/nakamasato/password-operator/bin/controller-gen --version | grep -q v0.11.3 || \
        GOBIN=/Users/m.naka/repos/nakamasato/password-operator/bin go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.11.3
/Users/m.naka/repos/nakamasato/password-operator/bin/controller-gen rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
/Users/m.naka/repos/nakamasato/password-operator/bin/kustomize build config/crd | kubectl apply -f -
error: unable to decode "STDIN": parsing time "null" as "2006-01-02T15:04:05Z07:00": cannot parse "null" as "2006"
make: *** [install] Error 1

export CONTROLLER_TOOLS_VERSION=v0.12.0 in .upgrade-version.sh <- This will be unnecessary in v3.11.0 (kubernetes-sigs/kubebuilder#3388)

kubernetes-sigs/kubebuilder#3316

Ref

https://github.com/kubernetes-sigs/kubebuilder/releases/tag/v3.10.0

Close #16

@nakamasato nakamasato merged commit 5f155e7 into main Jul 27, 2023
1 check passed
@nakamasato nakamasato deleted the upgrade-to-v3.10.0 branch July 27, 2023 23:55
@github-actions
Copy link

PR has been merged. we're publishing a new release! (Thu Jul 27 2023 23:56:08 GMT+0000 (Coordinated Universal Time))

@github-actions
Copy link

New release v0.0.7 has been published! (Thu Jul 27 2023 23:56:12 GMT+0000 (Coordinated Universal Time))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade kubebuilder to v3.10.0
1 participant