Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to CategoricalArrays and Missings #16

Merged
merged 6 commits into from
Nov 29, 2017
Merged

Conversation

nalimilan
Copy link
Owner

@nalimilan nalimilan commented Nov 29, 2017

Breaking change: rename usena to skipmissing, and change default
to keep missing values. Also rework CategoricalArray method to make
it simpler. Ensure that type inference works when input arrays do not
support missing values. Improve tests.

@quinnj Working with a DataFrame importing using CSV.jl gives corrupted WeakRefString objects in the following example:

using DataFrames, CSV
iris = CSV.read(joinpath(Pkg.dir("DataFrames"), "test/data/iris.csv"), categorical=false);
iris[:LongSepal] = iris[:SepalLength] .> 5.0
tab = freqtable(iris, :Species, :LongSepal)

Sometimes, printing tab fails since the dimension names appear to have been freed. That's really problematic. Any plans to prevent this?

EDIT: fixed by JuliaData/WeakRefStrings.jl#17 (comment).

Breaking change: rename usena to skipmissing, and change default
to keep missing values. Also rework CategoricalArray method to make
it simpler. Ensure that type inference works when input arrays do not
support missing values. Improve tests.
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.9%) to 95.455% when pulling cfdb1c8 on nl/dataframes0.11 into fca6888 on master.

@nalimilan nalimilan merged commit 78290d3 into master Nov 29, 2017
@nalimilan nalimilan deleted the nl/dataframes0.11 branch November 29, 2017 18:29
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.9%) to 95.455% when pulling cfdb1c8 on nl/dataframes0.11 into fca6888 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.9%) to 95.455% when pulling fa62b1b on nl/dataframes0.11 into fca6888 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants