std: optimize malloc in encoding

named-data · Dec 25, 2024 · 4134db7 · 4134db7
1 parent 469a1ef
commit 4134db7
Show file tree

Hide file tree

Showing 6 changed files with 96 additions and 48 deletions.
diff --git a/std/encoding/codegen/model.go b/std/encoding/codegen/model.go
@@ -74,7 +74,7 @@ func (m *TlvModel) GenInitEncoder(buf *bytes.Buffer) error {
 			encoder.length = l
 
 			{{if .NoCopy}}
-				wirePlan := make([]uint, 0)
+				wirePlan := make([]uint, 0, 16)
 				l = uint(0)
 				{{- range $f := .Fields}}
 					{{$f.GenEncodingWirePlan}}
@@ -106,11 +106,15 @@ func (m *TlvModel) GenEncodeInto(buf *bytes.Buffer) error {
 
 		func (encoder *{{.Name}}Encoder) Encode(value *{{.Name}}) enc.Wire {
 			{{if .NoCopy}}
+				total := uint(0)
+				for _, l := range encoder.wirePlan {
+					total += l
+				}
+				inner := make([]byte, total)
 				wire := make(enc.Wire, len(encoder.wirePlan))
 				for i, l := range encoder.wirePlan {
-					if l > 0 {
-						wire[i] = make([]byte, l)
-					}
+					wire[i] = inner[:l]
+					inner = inner[l:]
 				}
 				encoder.EncodeInto(value, wire)
 			{{else}}

diff --git a/std/encoding/tests/gen_basic/zz_generated.go b/std/encoding/tests/gen_basic/zz_generated.go
diff --git a/std/encoding/tests/gen_composition/zz_generated.go b/std/encoding/tests/gen_composition/zz_generated.go
diff --git a/std/encoding/tests/gen_signature/zz_generated.go b/std/encoding/tests/gen_signature/zz_generated.go
diff --git a/std/ndn/spec_2022/zz_generated.go b/std/ndn/spec_2022/zz_generated.go
diff --git a/std/schema/demosec/zz_generated.go b/std/schema/demosec/zz_generated.go