Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std: use string builder for Name::String() #106

Merged
merged 1 commit into from
Jan 14, 2025
Merged

std: use string builder for Name::String() #106

merged 1 commit into from
Jan 14, 2025

Conversation

pulsejet
Copy link
Collaborator

Strings in go are immutable, so each concat is an allocation.

String builder internally uses unsafe so I expect it's fast (lol)

@pulsejet pulsejet requested a review from zjkmxy January 14, 2025 20:42
@pulsejet pulsejet self-assigned this Jan 14, 2025
@pulsejet pulsejet added the std go-ndn issues label Jan 14, 2025
@zjkmxy zjkmxy merged commit d1c6b28 into main Jan 14, 2025
10 checks passed
@zjkmxy zjkmxy deleted the name-str branch January 14, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjkmxy zjkmxy zjkmxy approved these changes

Assignees

@pulsejet pulsejet

Labels
std go-ndn issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pulsejet @zjkmxy