Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NDNLP fragment reassembly #96

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Fix NDNLP fragment reassembly #96

merged 2 commits into from
Jan 3, 2025

Conversation

pulsejet
Copy link
Collaborator

@pulsejet pulsejet commented Jan 3, 2025

  1. Overhead calculation was broken
  2. Outgoing framents were incorrect
  3. Fix memleak when fragments are missed (ring buffer for reassembly instead of map)

@pulsejet pulsejet added the fw YaNFD issues label Jan 3, 2025
@pulsejet pulsejet requested a review from zjkmxy January 3, 2025 16:50
@pulsejet pulsejet self-assigned this Jan 3, 2025
@pulsejet pulsejet added the bug Something isn't working label Jan 3, 2025
@pulsejet pulsejet linked an issue Jan 3, 2025 that may be closed by this pull request
NDNLPLinkService reassembly leaks memory #65
Closed
zjkmxy
zjkmxy approved these changes Jan 3, 2025
View reviewed changes
fw/face/ndnlp-link-service.go Outdated Show resolved Hide resolved
@zjkmxy zjkmxy merged commit ade6724 into localhop Jan 3, 2025
8 checks passed
@zjkmxy zjkmxy deleted the frag branch January 3, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjkmxy zjkmxy zjkmxy approved these changes

Assignees

@pulsejet pulsejet

Labels
bug Something isn't working fw YaNFD issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NDNLPLinkService reassembly leaks memory
2 participants
@pulsejet @zjkmxy