Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test trivial fix #132

Merged
merged 2 commits into from
Aug 10, 2017
Merged

Test trivial fix #132

merged 2 commits into from
Aug 10, 2017

Conversation

sjp38
Copy link
Contributor

@sjp38 sjp38 commented Aug 10, 2017

Hi Namhyung,

I attended to your uftrace seminar today and got impressed so much. During the time, I found two trivial nitpicks by coincidence. So, here's the patches.

Thanks,
SeongJae Park

sjp38 added 2 commits August 10, 2017 19:21
@sjp38
test: Fix miss-spelled macro name, __FILE
325da5e 
__FILE__ is mistakenly typed as __FILE in unittest.h.  This commit fixes
it.

Signed-off-by: SeongJae Park <sj38.park@gmail.com>
Fixes: 97085be ("test: Show failing file:line in the unit test")
@sjp38
test: Show failing file:line in TEST_STREQ(), TEST_MEMEQ() failure
59545fc 
File name:line number information is very useful for debugging of test
failure .  However, TEST_STREQ() and TEST_MEMEQ() doesn't provide the
information though it receives the information from caller.  This commit
fixes the macro functions to show the information when test fails.

Signed-off-by: SeongJae Park <sj38.park@gmail.com>
Fixes: 97085be ("test: Show failing file:line in the unit test")
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
@namhyung
Copy link
Owner

Thanks for your kind word. The patches look good to me.

@namhyung namhyung merged commit 5e4e789 into namhyung:master Aug 10, 2017
honggyukim added a commit to honggyukim/uftrace that referenced this pull request Nov 25, 2019
@honggyukim
xxx: Make full dynamic tracing work for ARM
c74f428 
This implements full dynamic tracing for ARM.
The current status is that it can record uftrace itself, but only for
unoptimized binary.

The following patterns must be handled to support optimized binary.

  00034110 <start_pager>:
     34110:       e59f3084        ldr     r3, [pc, namhyung#132]  ; 3419c <start_pager+0x8c>
     34114:       e92d4010        push    {r4, lr}
     34118:       e1a0e000        mov     lr, r0
     3411c:       e893000f        ldm     r3, {r0, r1, r2, r3}

  00038280 <setup_field>:
     38280:       e92d4ff0        push    {r4, r5, r6, r7, r8, r9, sl, fp, lr}
     38284:       e3a0c000        mov     ip, #0
     38288:       e5914034        ldr     r4, [r1, namhyung#52]   ; 0x34
     3828c:       e24dd01c        sub     sp, sp, namhyung#28

  000482b4 <find_symtabs>:
     482b4:       e1a0c000        mov     ip, r0
     482b8:       e1c001d0        ldrd    r0, [r0, #16]
     482bc:       e92d4ff8        push    {r3, r4, r5, r6, r7, r8, r9, sl, fp, lr}
     482c0:       e1510003        cmp     r1, r3

THUMB code is not handled yet!

Signed-off-by: Honggyu Kim <honggyu.kp@gmail.com>
honggyukim added a commit to honggyukim/uftrace that referenced this pull request Nov 26, 2019
@honggyukim
xxx: Make full dynamic tracing work for ARM
c2848d3 
This implements full dynamic tracing for ARM.
The current status is that it can record uftrace itself, but only for
unoptimized binary.

The following patterns must be handled to support optimized binary.

  00034110 <start_pager>:
     34110:       e59f3084        ldr     r3, [pc, namhyung#132]  ; 3419c <start_pager+0x8c>
     34114:       e92d4010        push    {r4, lr}
     34118:       e1a0e000        mov     lr, r0
     3411c:       e893000f        ldm     r3, {r0, r1, r2, r3}

  00038280 <setup_field>:
     38280:       e92d4ff0        push    {r4, r5, r6, r7, r8, r9, sl, fp, lr}
     38284:       e3a0c000        mov     ip, #0
     38288:       e5914034        ldr     r4, [r1, namhyung#52]   ; 0x34
     3828c:       e24dd01c        sub     sp, sp, namhyung#28

  000482b4 <find_symtabs>:
     482b4:       e1a0c000        mov     ip, r0
     482b8:       e1c001d0        ldrd    r0, [r0, #16]
     482bc:       e92d4ff8        push    {r3, r4, r5, r6, r7, r8, r9, sl, fp, lr}
     482c0:       e1510003        cmp     r1, r3

THUMB code is not handled yet!

Signed-off-by: Honggyu Kim <honggyu.kp@gmail.com>
honggyukim added a commit to honggyukim/uftrace that referenced this pull request Dec 13, 2019
@honggyukim
xxx: Make full dynamic tracing work for ARM
323130f 
This implements full dynamic tracing for ARM.
The current status is that it can record uftrace itself, but only for
unoptimized binary.

The following patterns must be handled to support optimized binary.

  00034110 <start_pager>:
     34110:       e59f3084        ldr     r3, [pc, namhyung#132]  ; 3419c <start_pager+0x8c>
     34114:       e92d4010        push    {r4, lr}
     34118:       e1a0e000        mov     lr, r0
     3411c:       e893000f        ldm     r3, {r0, r1, r2, r3}

  00038280 <setup_field>:
     38280:       e92d4ff0        push    {r4, r5, r6, r7, r8, r9, sl, fp, lr}
     38284:       e3a0c000        mov     ip, #0
     38288:       e5914034        ldr     r4, [r1, namhyung#52]   ; 0x34
     3828c:       e24dd01c        sub     sp, sp, namhyung#28

  000482b4 <find_symtabs>:
     482b4:       e1a0c000        mov     ip, r0
     482b8:       e1c001d0        ldrd    r0, [r0, #16]
     482bc:       e92d4ff8        push    {r3, r4, r5, r6, r7, r8, r9, sl, fp, lr}
     482c0:       e1510003        cmp     r1, r3

THUMB code is not handled yet!

Signed-off-by: Honggyu Kim <honggyu.kp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjp38 @namhyung