Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils: Fix warnings implicit declaration of function 'close' #1860

Merged
merged 1 commit into from
Dec 17, 2023
Merged

utils: Fix warnings implicit declaration of function 'close' #1860

merged 1 commit into from
Dec 17, 2023

Conversation

paranlee
Copy link
Contributor

This patch fix warning on compile time with including unistd.h header file.

  utils/kernel-parser.c:151:9:
  warning: implicit declaration of function 'close';
  did you mean 'pclose'?
  [-Wimplicit-function-declaration]
    151 |         close(kp->fds[cpu]);
        |         ^~~~~
        |         pclose

Fixed: #1859

@paranlee @yunse0ngkim
utils: Fix warnings implicit declaration of function 'close'
3a27e0c 
This patch fix warning on compile time with including unistd.h
header file.

  utils/kernel-parser.c:151:9:
  warning: implicit declaration of function 'close';
  did you mean 'pclose'?
  [-Wimplicit-function-declaration]
    151 |         close(kp->fds[cpu]);
        |         ^~~~~
        |         pclose

Fixed: namhyung#1859
Signed-off-by: Paran Lee <p4ranlee@gmail.com>
namhyung
namhyung approved these changes Dec 17, 2023
View reviewed changes
Copy link
Owner

@namhyung namhyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

p.s. Warning messages like you added in the commit message can be longer than the normal messages as I think it's ok to keep the original shape. But I'm also fine with your change, thanks!

@namhyung namhyung merged commit 8f947dc into namhyung:master Dec 17, 2023
3 checks passed
@Porkepix Porkepix mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namhyung namhyung namhyung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

warning: implicit declaration of function 'close'
2 participants
@paranlee @namhyung