dwarf: Close file descriptors in setup_dwarf_info() #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namhyung
reviewed
Apr 20, 2024
namhyung
reviewed
Apr 20, 2024
This defect was detected by Facebook's Infer tool https://github.com/facebook/infer Signed-off-by: Ziming Zhou <zimingzh@umich.edu>
ziming-zh
force-pushed
the
fix_fileclose_deallocation
branch
from
99ae2d9 to
4f59089
Compare
|
Hi @namhyung, thanks for your comment! It seems that the static analysis tool |
|
Oops, I clicked a wrong button. Can you please force push the branch with the latest change and remove my merge commit? |
ziming-zh
force-pushed
the
fix_fileclose_deallocation
branch
from
63d8f9c to
4f59089
Compare
|
@namhyung done! |
ziming-zh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @namhyung,
I've also run Facebook's Infer tool to check for potential defection in the current code base. I've made three adjustment to close file descriptor in setup_dwarf_info function to release acquired resource in
utils/dwarfs.c. I've attached the complete infer report in bugs.txt and report.csv. The other detected defects seems trivial on my side. I'd be happy if you could take a look at them as well.