Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ukrainian language #38

Merged
merged 4 commits into from
Apr 7, 2024
Merged

Ukrainian language #38

merged 4 commits into from
Apr 7, 2024

Conversation

sweeteBatata
Copy link
Contributor

Ukrainian language

Ukrainian language
"RESTART": "Перезавантажити",
"RESTORED_BACKUP_SUCCESSFULLY": "Резервна копія відновлення",
"RESTORED_BACKUP_SUCCESSFULLY_SUB": "Файл резервної копії успішно відновлено",
"RESTORE_BACKUP": "Відновити резервну копію,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed "

"DEFAULT_DOWNLOAD_LOCATION": "Папка для завантаження за Замовчуванням",
"DEFAULT_LIBRARY_TAB": "Бібліотека за замовуванням",
"DELETE": "Видалити",
"DELETE_FILE_CACHE_SUBTITLE": "Delete _FILES_COUNT_ file representing _TOTAL_SIZE_?",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to translate

@@ -498,7 +498,7 @@
"RESTART": "Перезавантажити",
"RESTORED_BACKUP_SUCCESSFULLY": "Резервна копія відновлення",
"RESTORED_BACKUP_SUCCESSFULLY_SUB": "Файл резервної копії успішно відновлено",
"RESTORE_BACKUP": "Відновити резервну копію,
"RESTORE_BACKUP": "Відновити резервну копію,"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XD Don't hurry, put " before a comma

@VerySweetBread
Copy link
Contributor

You can check your translation puting .json file in language chooser. (Your current file causes an error
Screenshot_20240406_001618
)

@sweeteBatata
Copy link
Contributor Author

Used the localization file in the app, no errors.

Screenshot_20240406-002157_Namida

@VerySweetBread
Copy link
Contributor

hM
SmartSelect_20240406_002913
Anyway, it works

langs.json Outdated
Copy link
Contributor

@VerySweetBread VerySweetBread Apr 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something wrong with whitespaces... Will be the mainteiner problem)

@sweeteBatata
Copy link
Contributor Author

The Ukrainian language has some letters that are in extended Cyrillic fonts, "І" and "Ї". So, it's a font problem.

@VerySweetBread
Copy link
Contributor

The Ukrainian language has some letters that are in extended Cyrillic fonts, "І" and "Ї". So, it's a font problem.

Yep, and it's strange, 'cuz they are same Cyrillic letters as ы and й

@sweeteBatata
Copy link
Contributor Author

Yep, and it's strange, 'cuz they are same Cyrillic letters as ы and й

And the Belarusian language has the letter "Ў", it's just that these languages are less popular than Russian, and so you don't see them in fonts as often. In this case, I don't think it's a big problem, because if the devices have support for the Ukrainian language by default, then everything will be fine in the app.

@sweeteBatata sweeteBatata changed the title Add files via upload Ukrainian language Apr 6, 2024
@MSOB7YY
Copy link
Member

MSOB7YY commented Apr 7, 2024

woahh thank u soooo muchhhhh, gonna merge now

@Andrew1397
Copy link

hM SmartSelect_20240406_002913 Anyway, it works

How can this problem be solved?
My device supports the Ukrainian language and all programs perfectly display all letters, but in "Namida" there is such a problem

@MSOB7YY
Copy link
Member

MSOB7YY commented May 3, 2024

@Andrew1397 yeah font problem, tracking at namidaco/namida#183

@Andrew1397
Copy link

And with which font are there no problems?
Because I tried all the fonts available in Crdroid, but the problem remains. Or I did not understand at all what fonts you are talking about

@MSOB7YY
Copy link
Member

MSOB7YY commented May 3, 2024

@Andrew1397 the issue is with the custom font that namida uses, not your problem. i will check what i can do with that

@Andrew1397
Copy link

Now I understand.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants