chore: separate lrc font size for miniplayer & fullscreen

namidaco · Apr 27, 2024 · d7afa9a · d7afa9a
1 parent 2010c46
commit d7afa9a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/lib/controller/settings_controller.dart b/lib/controller/settings_controller.dart
@@ -274,6 +274,7 @@ class SettingsController with SettingsFileWriter {
   }.obs;
 
   double fontScaleLRC = 1.0;
+  double fontScaleLRCFull = 1.0;
 
   bool canAskForBatteryOptimizations = true;
   bool didSupportNamida = false;
@@ -487,6 +488,7 @@ class SettingsController with SettingsFileWriter {
       mediaItemsTrackSortingReverse.value = {for (final e in mediaItemsTrackSortingReverseInStorage.entries) MediaType.values.getEnum(e.key) ?? MediaType.track: e.value};
 
       fontScaleLRC = json['fontScaleLRC'] ?? fontScaleLRC;
+      fontScaleLRCFull = json['fontScaleLRCFull'] ?? fontScaleLRC; // fallback to normal
 
       canAskForBatteryOptimizations = json['canAskForBatteryOptimizations'] ?? canAskForBatteryOptimizations;
     } catch (e) {
@@ -648,6 +650,7 @@ class SettingsController with SettingsFileWriter {
         'mediaItemsTrackSortingReverse': mediaItemsTrackSortingReverse.map((key, value) => MapEntry(key.convertToString, value)),
 
         'fontScaleLRC': fontScaleLRC,
+        'fontScaleLRCFull': fontScaleLRCFull,
 
         'canAskForBatteryOptimizations': canAskForBatteryOptimizations,
       };
@@ -802,6 +805,7 @@ class SettingsController with SettingsFileWriter {
     DateRange? ytMostPlayedCustomDateRange,
     bool? ytMostPlayedCustomisStartOfDay,
     double? fontScaleLRC,
+    double? fontScaleLRCFull,
     bool? didSupportNamida,
     bool? canAskForBatteryOptimizations,
   }) {
@@ -1032,6 +1036,7 @@ class SettingsController with SettingsFileWriter {
     if (ytMostPlayedCustomisStartOfDay != null) this.ytMostPlayedCustomisStartOfDay.value = ytMostPlayedCustomisStartOfDay;
 
     if (fontScaleLRC != null) this.fontScaleLRC = fontScaleLRC;
+    if (fontScaleLRCFull != null) this.fontScaleLRCFull = fontScaleLRCFull;
 
     if (didSupportNamida != null) this.didSupportNamida = didSupportNamida;
     if (canAskForBatteryOptimizations != null) this.canAskForBatteryOptimizations = canAskForBatteryOptimizations;

diff --git a/lib/packages/lyrics_lrc_parsed_view.dart b/lib/packages/lyrics_lrc_parsed_view.dart
@@ -160,8 +160,8 @@ class LyricsLRCParsedViewState extends State<LyricsLRCParsedView> {
   var lyrics = <LrcLine>[];
   final timestampsMap = <Duration, (int, LrcLine)>{};
 
-  double _previousFontMultiplier = settings.fontScaleLRC;
-  double _fontMultiplier = settings.fontScaleLRC;
+  late double _previousFontMultiplier = widget.isFullScreenView ? settings.fontScaleLRCFull : settings.fontScaleLRC;
+  late double _fontMultiplier = widget.isFullScreenView ? settings.fontScaleLRCFull : settings.fontScaleLRC;
 
   @override
   void dispose() {
@@ -424,7 +424,7 @@ class LyricsLRCParsedViewState extends State<LyricsLRCParsedView> {
           child: ScaleDetector(
             onScaleStart: (details) => _previousFontMultiplier = _fontMultiplier,
             onScaleUpdate: (details) => setState(() => _fontMultiplier = (details.scale * _previousFontMultiplier).clamp(0.5, 2.0)),
-            onScaleEnd: (details) => settings.save(fontScaleLRC: _fontMultiplier),
+            onScaleEnd: (details) => widget.isFullScreenView ? settings.save(fontScaleLRCFull: _fontMultiplier) : settings.save(fontScaleLRC: _fontMultiplier),
           ),
         ),
       ],

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,7 +1,7 @@
 name: namida
 description: A Beautiful and Feature-rich Music Player, With YouTube & Video Support Built in Flutter
 publish_to: "none"
-version: 2.0.8-beta+240427224
+version: 2.0.9-beta+240427234
 
 environment:
   sdk: ">=3.1.4 <4.0.0"