Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Previous button replays #112

Closed
z9xx7o0 opened this issue Jan 20, 2024 · 5 comments
Closed

[FEATURE REQUEST] Previous button replays #112

z9xx7o0 opened this issue Jan 20, 2024 · 5 comments

Comments

@z9xx7o0
Copy link

z9xx7o0 commented Jan 20, 2024

The previous button replays the current track. You can also make a toggle in the settings. Also, if you could make it that it works from any input method so I can do it from the miniplayer, notifications, or Bluetooth gestures.

@MSOB7YY MSOB7YY changed the title Feature request [FEATURE REQUEST] Previous button replays Jan 20, 2024
@MSOB7YY
Copy link
Member

MSOB7YY commented Jan 20, 2024

this behavior is honestly annoying, but bothways if it gets implemented it would be from any input.
you can currently long press the position text tho.

@z9xx7o0
Copy link
Author

z9xx7o0 commented Jan 20, 2024

I dont mean the button always acts as a replay button that would be very annoying. What I meant is that when the track is more than 5 seconds in, the previous button acts as a replay button, but when it's at the beginning, it acts as normally.

So if I'm playing a track and want to go back I just press the button twice, the first time it restarts the song from the beginning, now it's less than 5 seconds in, when I press it the second time it goes back to the previous track.

That's the behaviour I'm used to in every android player I've used. Also, you could add a toggle in the settings for the user to select if they want this behaviour or the one that we currently have.

Also, I don't know if it's 5 seconds. That's just a guess, so please check beforehand.

@MSOB7YY
Copy link
Member

MSOB7YY commented Jan 20, 2024

oh ofc ofc i know this, but still personally i don't like it.
it will be controlled by the seek duration inside settings
Screenshot_20240120-201028_Namida

and surely it will be optional, only concern that prevents this is to not get settings page bloated, i have to carefully decide which options are really important, but dw i will get to this later

@z9xx7o0
Copy link
Author

z9xx7o0 commented Jan 20, 2024

OK, no problem, but can this be controlled by the notifications or Bluetooth device?

Also this reminds me, there is a small bug with the "minimum track duration to restore last played position" when I set it to don't restore, the next time I open the app, it automatically becomes always restore. So currently, I have it set to 120m.

@MSOB7YY
Copy link
Member

MSOB7YY commented Jan 20, 2024

opsss ur right thanks for pointing out, gonna check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants