-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] Separate lyrics font size in miniplayer and in lrc fullscreen #160
Comments
i dont get what exactly is the issue, lyrics font size is bigger in fullscreen and always has been, check namida/lib/packages/lyrics_lrc_parsed_view.dart Lines 177 to 178 in 492813e
|
Then i think it should be same for both |
i don't think so, the focus on lyrics in fullscreen is not the same as when viewed along with other ui elements |
As mentioned, the size on thumbnail becomes too small when size in fullscreen isn't big enough. So you have to manually change the size for thumbnail lyrics again if you want to read lyrics there and then need to change it again for fullscreen. That's what i was referring to. But also i don't use thumbnail lyrics a lot so i guess it's fine. Closing the issue |
hmmm maybe an easier solution is to separate font scale for both expanded lyrics and normal, gonna look into it |
they are now separated in d7afa9a <3 |
I set a medium text size for lyrics and they appeared fine for a while on thumbnail but then got too small
![IMG_20240408_105328](https://private-user-images.githubusercontent.com/99175083/320362633-f6e79968-f117-401e-bf58-a2a18cfbc6b0.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI0MTI5MTgsIm5iZiI6MTcyMjQxMjYxOCwicGF0aCI6Ii85OTE3NTA4My8zMjAzNjI2MzMtZjZlNzk5NjgtZjExNy00MDFlLWJmNTgtYTJhMThjZmJjNmIwLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MzElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzMxVDA3NTY1OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU1YzZiOGQ3ZTc1NjY4ZmU4NjFhMTM0YWZiYmU3MmE4MWVkZTI5ODNmNmRmNGNhNmU3Nzg5MWJjNjc5ZGNhNTEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.EgmuaKnTPU2oIAvAdvxQ-Soabm41Lr6URjy2Az-8yUk)
The text was updated successfully, but these errors were encountered: