Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Separate lyrics font size in miniplayer and in lrc fullscreen #160

Closed
NikunjKhangwal opened this issue Apr 8, 2024 · 8 comments

Comments

@NikunjKhangwal
Copy link

I set a medium text size for lyrics and they appeared fine for a while on thumbnail but then got too small
IMG_20240408_105328

@NikunjKhangwal
Copy link
Author

Looks like the size is applied directly for both
IMG_20240408_105643

@MSOB7YY
Copy link
Member

MSOB7YY commented Apr 11, 2024

i dont get what exactly is the issue, lyrics font size is bigger in fullscreen and always has been, check

final initialFontSize = fullscreen ? 25.0 : 15.0;
final normalTextStyle = context.textTheme.displayMedium!.copyWith(fontSize: _fontMultiplier * initialFontSize.multipliedFontScale);

@NikunjKhangwal
Copy link
Author

Then i think it should be same for both

@MSOB7YY
Copy link
Member

MSOB7YY commented Apr 12, 2024

i don't think so, the focus on lyrics in fullscreen is not the same as when viewed along with other ui elements

@NikunjKhangwal
Copy link
Author

As mentioned, the size on thumbnail becomes too small when size in fullscreen isn't big enough. So you have to manually change the size for thumbnail lyrics again if you want to read lyrics there and then need to change it again for fullscreen. That's what i was referring to.

But also i don't use thumbnail lyrics a lot so i guess it's fine. Closing the issue

@MSOB7YY
Copy link
Member

MSOB7YY commented Apr 12, 2024

hmmm maybe an easier solution is to separate font scale for both expanded lyrics and normal, gonna look into it

@MSOB7YY MSOB7YY reopened this Apr 12, 2024
@MSOB7YY MSOB7YY changed the title [Bug] Lyrics size differing from expanded to thumbnail [FEATURE REQUEST] Separate lyrics font size in miniplayer and in lrc fullscreen Apr 12, 2024
@MSOB7YY
Copy link
Member

MSOB7YY commented Apr 27, 2024

they are now separated in d7afa9a <3

@MSOB7YY MSOB7YY closed this as completed Apr 27, 2024
@NikunjKhangwal
Copy link
Author

Keep cooking like this

bear-byebear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants