Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE] make lyrics searching easier #174

Closed
aneesh1122 opened this issue Apr 14, 2024 · 2 comments
Closed

[ISSUE] make lyrics searching easier #174

aneesh1122 opened this issue Apr 14, 2024 · 2 comments

Comments

@aneesh1122
Copy link

aneesh1122 commented Apr 14, 2024

  1. When I write the name of the song in the lyrics search bar and press enter, it takes me to the next line

  2. The song's title is not editable. The app makes us write the whole song's name while searching for lyrics.

Expected Behavior

  1. I expected it to search the lyrics whenever I press enter.

So, after writing the name of the song I have to press back button and then select the 'search' button which works but it's more convenient to press enter and get the lyrics results.

  1. I expected to be able to edit or modify the existing song's name

Screenshots

IMG_20240414_121137.jpg

Logs

Possible Solution

@MSOB7YY
Copy link
Member

MSOB7YY commented Apr 14, 2024

ur probably right that's definitely more convenient, gonna check immediately

MSOB7YY added a commit that referenced this issue May 10, 2024
@MSOB7YY
Copy link
Member

MSOB7YY commented May 10, 2024

as referenced:

  1. 'enter' button will search instead of new line
  2. unfortunately, u will need to press a small icon to imprint the text and be able to edit, thats because the default search is achieved by obtaining the exact lyrics for the artist & title, whileas searching just searches the query which should have lower matching compared to the first approach.

final params = [
if (title != '') 'track_name=$title',
if (artist != '') 'artist_name=${artist.split('(').first.split('[').first}',
if (album != '') 'album_name=$album',
].join('&');
if (params.isNotEmpty || customQuery != '') {
final tail = customQuery == '' ? params : 'q=$customQuery';
final urlPre = "https://lrclib.net/api/search?$tail";
final url = Uri.parse(Uri.encodeFull(urlPre));

@MSOB7YY MSOB7YY closed this as completed May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants