Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unsupported font in lyrics. #188

Closed
Not-James-Bond opened this issue May 11, 2024 · 7 comments
Closed

[BUG] Unsupported font in lyrics. #188

Not-James-Bond opened this issue May 11, 2024 · 7 comments

Comments

@Not-James-Bond
Copy link

Not-James-Bond commented May 11, 2024

Some LRC lyrics shows some kind of gibberish text (Usually in Hindi songs)

Expected Behavior

Supported readable lyrics should be visible.

Current Behavior

Unsupported font was being shown for few songs.

Steps to Reproduce

  1. Open Namida.
  2. Play music "Khudi by Local Train"
  3. Open Lyrics.
  4. Unsupported font will be shown.

Screenshots

Screenshot_20240512-033358
Screenshot_20240512-033146

Logs

Possible Solution

@MSOB7YY
Copy link
Member

MSOB7YY commented May 11, 2024

this was a font issue and was fixed in an earlier commit. wait the new release or use beta version from github action tab.

bothways this duplicate of #183

@MSOB7YY MSOB7YY closed this as completed May 11, 2024
@Not-James-Bond
Copy link
Author

Not-James-Bond commented May 12, 2024

this was a font issue and was fixed in an earlier commit. wait the new release or use beta version from github action tab.

bothways this duplicate of #183

Used the latest build from GitHub action workflow: https://github.com/namidaco/namida/actions/runs/9037354238

Still same lyrics issue.
Screenshot_20240512-125343
Screenshot_20240512-125401_Namida

.

@MSOB7YY
Copy link
Member

MSOB7YY commented May 12, 2024

@MSOB7YY MSOB7YY reopened this May 12, 2024
@Not-James-Bond
Copy link
Author

It seems on few lyrics it's working but on others it's not.

@MSOB7YY
Copy link
Member

MSOB7YY commented May 14, 2024

@Not-James-Bond lyrics issues are all fixed now, gonna push soon and then u may use beta or wait the stable release in a week

@Not-James-Bond
Copy link
Author

@MSOB7YY I'll test out the beta and probably will switch to stable later. Thanks. Mind Sharing the PR as well? I'd like to see the changes.

MSOB7YY added a commit that referenced this issue May 14, 2024
@MSOB7YY
Copy link
Member

MSOB7YY commented May 14, 2024

@Not-James-Bond yeah i just pushed, the fix is done in 47c2351 (was due to default parsing behavior that supposes everything is latin)

other lyrics improvements can be seen for example in bb27bf3, 060ccef, 7a63a6e, f59f23f, 9eecbcb & dynamic lyrics feature in 8426584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants