Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE] no size settings for player buttons (playlist, lyrics, equalizer) #192

Closed
nuser222 opened this issue May 14, 2024 · 2 comments
Closed

Comments

@nuser222
Copy link

nuser222 commented May 14, 2024

Hello,
my big fingers have a problem to hit the correct button. The curved display of my android smartphone makes it even worse. Is it possible to implement an setting for icon size and spacing?

Screenshots

nami

would be cool if possible because otherwise the player is almost perfect but this makes it unusable for me
)))

@MSOB7YY
Copy link
Member

MSOB7YY commented May 14, 2024

uhh is it really unusable? the buttons may look small but they have decent hittest around it (around 48 pixels iirc) which is like most action buttons out there in other apps

im not against extra settings but allowing to customize miniplayer dimensions will make it a mess, the only way is maybe make them a bit bigger but again is it worth the design vs usability? like sorry i dont know how big finger affects it, i tried using my whole thumb and it still hit the nearest button normally so what is the actual issue for it?

@MSOB7YY
Copy link
Member

MSOB7YY commented Aug 31, 2024

i really keep trying to reproduce but buttons already have a good hit-test

icon size 20px vs 22px.. looks awful tbh
image
image

i ended up increasing the padding a liiil bit (+2px vertical & +4px horizontal), which doesnt affect look but may help. sorry this is like the most i could do, otherwise the spacing is just too much

changes will be in v4.0.9 or higher https://github.com/namidaco/namida-snapshots/releases/

@MSOB7YY MSOB7YY closed this as not planned Won't fix, can't repro, duplicate, stale Aug 31, 2024
MSOB7YY added a commit that referenced this issue Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants