Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features requests/ bug in the latest app version #21

Closed
4 tasks done
hibonox705 opened this issue Oct 14, 2023 · 12 comments
Closed
4 tasks done

Features requests/ bug in the latest app version #21

hibonox705 opened this issue Oct 14, 2023 · 12 comments

Comments

@hibonox705
Copy link

hibonox705 commented Oct 14, 2023

Hi,

First of all love your app, it's really nice to have a new looking music and video app.
I don't know how hard it's to code it but i have different request and bugs to report.

The first one is that the album artist filter for the artists category doesn't work and show every artists (including the artists that are features on a song) individually, instead of having the artists you have an album from.

The second one is to have the ability to order tracks of an album (by track number per example). Because when wanting to listen to one they just show up in whatever order.

Third one is that in the indexer section, album identifiers. We can't select and save anything but the already pre-selected Name setting.


UPDATE:
with v1.4.8, issue is partially resolved

  • Album Artists tab, along with search
  • subpages tracks sorting (b82dce2) (available since v1.5.4)
  • album tracks sorting fix
  • album identifiers saving in settings
@MSOB7YY
Copy link
Member

MSOB7YY commented Oct 15, 2023

thank you so much, im glad u like my app
now for ur requests

  1. i don't quite get what is the expected behavior, are u talking about the sort or the mini search filter? sorting & search filter both works as intended
    • featured artists appearing as a separate entry is actually a feature for a more organized library, yet u can still disable from indexer "Extract feat. artists"
  2. previously album tracks were sorted by year or title, i didnt know ppl want their albums to be sorted normally 😶‍🌫️ next release has a fix for this, while exposing all searching alternatives are also requested, i might get working on it sooner
  3. how come? the name is forcely enabled, while u get year and album artist as extra, do you mean u can't select those 2? can u send a video please?

@PlumBlossoms13
Copy link

For point three, you can select 'year' and 'album artist' just fine but the save button doesn't work.

@Red6785
Copy link

Red6785 commented Oct 15, 2023 via email

@MSOB7YY
Copy link
Member

MSOB7YY commented Oct 15, 2023

oh ops, a fix has been pushed 1bcee8b
apparently i was only activating it if the values are not the same

enabled: !settings.albumIdentifiers.every((element) => tempList.contains(element)), // isEqualTo wont work cuz order shouldnt matter

@hibonox705
Copy link
Author

thank you so much, im glad u like my app now for ur requests

  1. i don't quite get what is the expected behavior, are u talking about the sort or the mini search filter? sorting & search filter both works as intended

    • featured artists appearing as a separate entry is actually a feature for a more organized library, yet u can still disable from indexer "Extract feat. artists"
  2. previously album tracks were sorted by year or title, i didnt know ppl want their albums to be sorted normally 😶‍🌫️ next release has a fix for this, while exposing all searching alternatives are also requested, i might get working on it sooner

  3. how come? the name is forcely enabled, while u get year and album artist as extra, do you mean u can't select those 2? can u send a video please?

No problem, thank you for developing such an app

Basically I'm comparing it to other music app where album artist show the artists that you have albums and singles from them. The original artist that released it

And no problem for the other suggestions I will wait for the update when it comes out

@MSOB7YY
Copy link
Member

MSOB7YY commented Oct 15, 2023

i think i got what u want now

currently the library is organized by every artist, would your issue get resolved by adding a separate Album Artists tab ?


also thanks, the new version is going to be published tomorrow

@hibonox705
Copy link
Author

i think i got what u want now

currently the library is organized by every artist, would your issue get resolved by adding a separate Album Artists tab ?

also thanks, the new version is going to be published tomorrow

Yes if possible of course

Oh nice can't wait to have a look at it

@MSOB7YY
Copy link
Member

MSOB7YY commented Oct 16, 2023

with v1.4.8, issue is partially resolved

  • Album Artists tab, along with search
  • subpages tracks sorting (b82dce2) (available since v1.5.4)
  • album tracks sorting fix
  • album identifiers saving in settings

@hibonox705
Copy link
Author

with v1.4.8, issue is partially resolved

  • Album Artists tab, along with search
  • subpages tracks sorting
  • album tracks sorting fix
  • album identifiers saving in settings

Yeah just saw the update thanks for doing so.
And for the rest no problem don't rush, take your time. It's already mind blowing having a music player like this on GitHub, so no rush for the rest. Take your time and take time for yourself don't burn yourself out

@MSOB7YY
Copy link
Member

MSOB7YY commented Oct 16, 2023

thank u so much really, i do this because i love it so dw, ty 🌺

@MSOB7YY
Copy link
Member

MSOB7YY commented Apr 7, 2024

as mentioned, Album Artists and Composers are now available as a dropdown button in artists page, this one took a while ty for being patient

@hibonox705
Copy link
Author

Let's go, thanks for taking time to develop it and implementing it.
Just updated the app and it works flawlessly 👌

@ArhnZd ArhnZd mentioned this issue Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants