Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Set As Ringtone #4

Closed
Red6785 opened this issue Oct 8, 2023 · 8 comments
Closed

Feature Request - Set As Ringtone #4

Red6785 opened this issue Oct 8, 2023 · 8 comments

Comments

@Red6785
Copy link

Red6785 commented Oct 8, 2023

Musicolet has a feature that allows you to set a song as your ringtone in the app if you have it downloaded locally. I think it's a good feature that deserves a home here, too.

@MSOB7YY
Copy link
Member

MSOB7YY commented Oct 8, 2023

Alright, although there is really no more place inside track dialog so it will live inside advanced.. forever and ever

@NikunjKhangwal
Copy link

+1
@MSOB7YY Isn't it possible to make the dialog scrollable?

@MSOB7YY
Copy link
Member

MSOB7YY commented Nov 28, 2023

@NikunjKhangwal

it is already? but the whole thing is scrollable, not just the middle items


update: this one is taking quite a while, the permissions needed to modify ringtone etc is pain, i would need to work on the native side myself

@NikunjKhangwal
Copy link

No, i was talking about the three dot menu list where "advanced" button is since you said there isn't enough place for a set as ringtone button. Not the song metadata list that appears when you click on Song name.

@MSOB7YY
Copy link
Member

MSOB7YY commented Nov 28, 2023

@NikunjKhangwal

oh what i mean by "no enough space" is that dialog can get bloated with items, which uhhh- gets annoying to look at

there are few items (3-4) that appears on demand depending on the track itself, so having another item there always is just a bad idea

imo its a good place in "advanced", one doesn't constantly change their ringtone

@NikunjKhangwal
Copy link

I see, here i was about about to suggest other two buttons for the menu lmao ☠️

@MSOB7YY
Copy link
Member

MSOB7YY commented Nov 28, 2023

@NikunjKhangwal
ofc u can! it wont be the first time to suggest something u not gonna see 💖
what are them?

@NikunjKhangwal
Copy link

Equalizer Button (This could lead to system equaliser since the app doesn't have one of it's own OR a third party one if installed). This is something people use often.
Second was a sleep timer button, i thought it would be easier to use than sidebar but on a 2nd thought both take about the same effort so just ignore this one. If you make audio info appear in two line as mentioned in #50 then consider adding sleep timer button before repeat button when there's enough space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants