Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug and enhancement #50

Closed
BlackSparkz opened this issue Nov 7, 2023 · 7 comments
Closed

Bug and enhancement #50

BlackSparkz opened this issue Nov 7, 2023 · 7 comments

Comments

@BlackSparkz
Copy link

Screenshot_20231107_113253.png

Screenshot_20231107_110500.png

Screenshot_20231107_110316.png

Fix all

@MSOB7YY
Copy link
Member

MSOB7YY commented Nov 14, 2023

  1. investigating
  2. was fixed
  3. not possible, u can swipe to the right a bit to have a peek
  4. maybe its time to reduce font size a bit from Customization Settings, i cant make it take more than 1 line

@NikunjKhangwal
Copy link

Can Confirm, expanded lyrics button doesn't work a lot of times for me as well. Also yes make the audio info take two lines if it's overlapping. You can also move the repeat button above queue button since there's enough empty space along with a new "sleep timer" button above lyrics button. (Was going to make a new feature request for sleep timer button)

@MSOB7YY
Copy link
Member

MSOB7YY commented Nov 28, 2023

@NikunjKhangwal
after investigating, it seems like the issue is caused by scaling the artwork (AnimatedScale) which might not allow touches outside the original size.

im not very sure about workarounds, there isnt any place for this button in the miniplayer ui

about making the info 2 lined, and possibly introduce sleep timer (by making 4 squared icons), it will require some painy refactor and i don't think it will even look good, especially the 4 squared icons

ughhh im not sure yet

@NikunjKhangwal
Copy link

Yeah, fair point. You should at least make the info take 2 lines tho since that overlap doesn't look good either.
Also unless i'm missing something, why do you call the main playing screen "miniplayer"? I thought miniplayer was the one that appears when you swipe down the main player (With only back play/pause and previous button). I'm going to create a issue for this and i don't want it to be confusing.

@MSOB7YY
Copy link
Member

MSOB7YY commented Nov 28, 2023

okay i will look into that after a while

well to be technically right, its exactly "expanded miniplayer", others could work too like player screen or whatever, its just my view, could be wrong.

u can create the issue with any name u like as long as it's clearly referring to it

@NikunjKhangwal
Copy link

Got it, thanks

@MSOB7YY
Copy link
Member

MSOB7YY commented Dec 3, 2023

with [2031d74], number 1 (enter lrc fullscreen) can be fixed using 2 ways:

  1. since artwork scaling is now possible, u can make it a bit smaller, this will make the button work properly
  2. you can also just pinch in (zoom) when lrc view is displayed, and it will enter fullscreen

unfortunately, the core issue (button should be pressed) doesnt seem to be fixable, since scaling up the artwork doesnt scale the GestureDetector hit test area.

for reference:

  1. GestureDetector doesn't respond correctly after transition with Transform widget flutter/flutter#27587
  2. Opt a subtree out of hitTestSelf culling flutter/flutter#75747

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants