Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lrc file isn't getting picked up automatically #46

Closed
NikunjKhangwal opened this issue Nov 1, 2023 · 2 comments
Closed

Lrc file isn't getting picked up automatically #46

NikunjKhangwal opened this issue Nov 1, 2023 · 2 comments

Comments

@NikunjKhangwal
Copy link

I have both the music and lrc file saved in same directory with same name.
IMG_20231101_150233
However the app didn't scan for the lrc file automatically after i refreshed the library. I have to manually select it from my file explorer
Screenshot_2023-11-01-15-03-07-291_com msob7y namida

@MSOB7YY
Copy link
Member

MSOB7YY commented Nov 1, 2023

oh thanks for the notice, by default lrc in the same directory is preferred over fetching

the issue here is that the lrc file name should have the full name of track

File lyricsFileDevice(Track tr) => File(p.join(tr.path.getDirectoryPath, "${tr.filename}.lrc"));

(in ur case, it should end with .m4a.lrc

  • will push a fix to also include files like yours

MSOB7YY added a commit that referenced this issue Nov 2, 2023
MSOB7YY added a commit that referenced this issue Nov 2, 2023
@MSOB7YY
Copy link
Member

MSOB7YY commented Nov 2, 2023

should be fixed with 20cb638, thanks for reporting 🌺

@MSOB7YY MSOB7YY closed this as completed Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants