Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] add accessible shuffle button. #88

Closed
z9xx7o0 opened this issue Dec 26, 2023 · 5 comments
Closed

[FEATURE REQUEST] add accessible shuffle button. #88

z9xx7o0 opened this issue Dec 26, 2023 · 5 comments

Comments

@z9xx7o0
Copy link

z9xx7o0 commented Dec 26, 2023

Add a shuffle button that is easily accessible because, currently, you need to go to the queue to find the shuffle button. Also, there is a small problem if I start listening to a song in the middle of a playlist, then use the shuffle button it only shuffles songs that are after the song's position in the playlist. It would be better if it also included the songs before. Like Spotify and YouTube music.

@MSOB7YY
Copy link
Member

MSOB7YY commented Dec 26, 2023

it actually already exists
settings > extras > floating action button
and choose "shuffle"

for the second part, u can also long press "shuffle" button and choose "shuffle all", this will shuffle the whole queue instead of the next tracks

@MSOB7YY MSOB7YY closed this as completed Dec 26, 2023
@z9xx7o0
Copy link
Author

z9xx7o0 commented Dec 26, 2023

@MSOB7YY , There is still a little problem. See this video of me comparing Namida, Spotify, and YouTube music. Notice how when I shuffle in Namida, the current track goes to a random location in the queue. While in YouTube music and Spotify, it is always the first in the queue. Also, see the conveniently placed shuffle button? That is mandatory for any music player. https://github.com/namidaco/namida/assets/83415416/5865c183-a389-43e7-b539-8e25809fd345

@MSOB7YY
Copy link
Member

MSOB7YY commented Dec 26, 2023

oh i see then. shuffling all should definitely put the playing track at first.

as for shuffle button in the player ui, i dont think its really possible, the ui is pretty condensed, moving the duration text above and putting buttons instead will kinda feel cluttered (the bottom buttons are a replacement for this)
also the shuffling here is quite different, u just shuffle when u want to shuffle. enabling/disabling shuffling doesnt make sense to me, so putting it directly in the ui won't make sense

@z9xx7o0
Copy link
Author

z9xx7o0 commented Dec 26, 2023

@MSOB7YY , I apologise for stretching this out it is a very small thing. If it's alright, I have a suggestion. You could add a small shuffle button next to the loop button or long press the loop to shuffle. Example.jpg

@MSOB7YY
Copy link
Member

MSOB7YY commented Dec 27, 2023

@z9xx7o0 ikr but the left button can contain some info which can cause overflow
wether video playback is enabled, or "audio info" is enabled in customization

and also as said shuffling mechanism doesnt suit the player ui, it has to be with the queue itself or idk thats how i think

nice editing skills tho :>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants