Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve crash inside buySkuComplete #247

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Resolve crash inside buySkuComplete #247

merged 3 commits into from
Sep 12, 2023

Conversation

namidan
Copy link
Contributor

@namidan namidan commented Sep 12, 2023

  • Resolve a crash when we try to create a NamiSKU object inside of the android side of the bridge buySkuComplete. The NamiSKU data class constructor was not reliably available if the RN bridge was compiled with a different native SDK jar than what the app used in implementation. The issue is resolved by exposing a more directly public method for creating NamiSKU

@namidan namidan marked this pull request as ready for review September 12, 2023 22:35
@namidan namidan merged commit b28cd12 into main Sep 12, 2023
4 of 5 checks passed
@namidan namidan deleted the bugfix/fix-nami-sku-crash branch September 12, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaricleroberts amaricleroberts amaricleroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namidan @amaricleroberts