Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up tv sample app #259

Merged
merged 2 commits into from
Sep 27, 2023
Merged

clean up tv sample app #259

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb538e9
clean up tv sample app
namidan Sep 27, 2023
2f95ad9
eslint
namidan Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions examples/TestNamiTV/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ android {
release {
// Caution! In production, you need to generate your own keystore file.
// see https://facebook.github.io/react-native/docs/signed-apk-android.
signingConfig null
signingConfig signingConfigs.release
minifyEnabled enableProguardInReleaseBuilds
proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
}
Expand Down Expand Up @@ -227,8 +227,8 @@ dependencies {
implementation "com.facebook.react:react-native:+" // From node_modules
implementation 'com.github.jeziellago:compose-markdown:0.3.0'

amazonImplementation "com.namiml:sdk-amazon::3.1.13"
playImplementation "com.namiml:sdk-android::3.1.13"
amazonImplementation "com.namiml:sdk-amazon:3.1.13"
playImplementation "com.namiml:sdk-android:3.1.13"

if (enableHermes) {
def hermesPath = "../../node_modules/hermes-engine/android/";
Expand Down
2 changes: 1 addition & 1 deletion examples/TestNamiTV/config/getInitialConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const getInitialConfig = () => {
);
case 'ios':
return JSON.stringify(
flavor !== 'production'
flavor === 'production'
? initAppleProductionConfig
: initAppleStageConfig,
);
Expand Down
13 changes: 11 additions & 2 deletions examples/TestNamiTV/config/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,14 @@
namiCommands: ['useStagingAPI'],
initialConfig: getInitialConfig(),
};
case 'production':

Check failure on line 17 in examples/TestNamiTV/config/index.ts

View workflow job for this annotation

GitHub Actions / ESLint 

Expected indentation of 4 spaces but found 6
return {

Check failure on line 18 in examples/TestNamiTV/config/index.ts

View workflow job for this annotation

GitHub Actions / ESLint 

Expected indentation of 6 spaces but found 8
'appPlatformID-apple': 'APPLE_PROD_APP_PLATFORM_ID',

Check failure on line 19 in examples/TestNamiTV/config/index.ts

View workflow job for this annotation

GitHub Actions / ESLint 

Expected indentation of 8 spaces but found 10
'appPlatformID-android': 'UNUSED',

Check failure on line 20 in examples/TestNamiTV/config/index.ts

View workflow job for this annotation

GitHub Actions / ESLint 

Expected indentation of 8 spaces but found 10
logLevel: 'DEBUG',

Check failure on line 21 in examples/TestNamiTV/config/index.ts

View workflow job for this annotation

GitHub Actions / ESLint 

Expected indentation of 8 spaces but found 10
namiCommands: ['useStagingAPI'],

Check failure on line 22 in examples/TestNamiTV/config/index.ts

View workflow job for this annotation

GitHub Actions / ESLint 

Expected indentation of 8 spaces but found 10
initialConfig: getInitialConfig(),

Check failure on line 23 in examples/TestNamiTV/config/index.ts

View workflow job for this annotation

GitHub Actions / ESLint 

Expected indentation of 8 spaces but found 10
};

Check failure on line 24 in examples/TestNamiTV/config/index.ts

View workflow job for this annotation

GitHub Actions / ESLint 

Expected indentation of 6 spaces but found 8
case 'stagingAmazon':
return {
'appPlatformID-apple': 'UNUSED',
Expand All @@ -22,7 +30,7 @@
namiCommands: ['useStagingAPI'],
initialConfig: getInitialConfig(),
};
case 'stagingGoogle':
case 'stagingPlay':
return {
'appPlatformID-apple': 'UNUSED',
'appPlatformID-android': 'GOOGLE_PROD_APP_PLATFORM_ID',
Expand All @@ -38,7 +46,7 @@
namiCommands: ['useStagingAPI'],
initialConfig: getInitialConfig(),
};
case 'productionGoogle':
case 'productionPlay':
return {
'appPlatformID-apple': 'UNUSED',
'appPlatformID-android': 'GOOGLE_PROD_APP_PLATFORM_ID',
Expand All @@ -51,6 +59,7 @@
'appPlatformID-apple': 'APPLE_PROD_APP_PLATFORM_ID',
'appPlatformID-android': 'GOOGLE_PROD_APP_PLATFORM_ID',
logLevel: 'DEBUG',
namiCommands: ['useStagingAPI'],
initialConfig: getInitialConfig(),
};
}
Expand Down
2 changes: 1 addition & 1 deletion examples/TestNamiTV/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const Root = () => {
const [isConfigurationComplete, setIsConfigurationComplete] = useState();
useEffect(() => {
Nami.configure(configDict, (resultObject) => {
setIsConfigurationComplete(resultObject.success);
setIsConfigurationComplete(true);
});
// eslint-disable-next-line @typescript-eslint/no-empty-function
return () => {};
Expand Down
2 changes: 1 addition & 1 deletion examples/TestNamiTV/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"react-native-nami-sdk": "file:../../",
"react-native-reanimated": "^2.3.1",
"react-native-safe-area-context": "^3.3.2",
"react-native-screens": "^3.20.0"
"react-native-screens": "3.18.0"
},
"devDependencies": {
"@babel/core": "^7.16.5",
Expand Down
Loading