Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paywall event sku bugfix #340

Merged
merged 1 commit into from
Aug 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class NamiCampaignManagerBridgeModule(reactContext: ReactApplicationContext) :
const val CAMPAIGN_LABEL = "campaignLabel"
const val PAYWALL_ID = "paywallId"
const val ACTION = "action"
const val SKU_ID = "skuId"
const val SKU = "sku"
const val PURCHASE_ERROR = "purchaseError"
const val PURCHASES = "purchases"
const val CAMPAIGN_NAME = "campaignName"
Expand Down Expand Up @@ -153,7 +153,6 @@ class NamiCampaignManagerBridgeModule(reactContext: ReactApplicationContext) :
actionCallback: Callback,
) {
val actionString = paywallEvent.action.toString()
val skuString = paywallEvent.sku?.skuId ?: ""

val purchasesArray = createPurchaseArray(paywallEvent.purchases)

Expand All @@ -163,7 +162,6 @@ class NamiCampaignManagerBridgeModule(reactContext: ReactApplicationContext) :
putString(CAMPAIGN_LABEL, paywallEvent.campaignLabel ?: "")
putString(PAYWALL_ID, paywallEvent.paywallId)
putString(ACTION, actionString)
putString(SKU_ID, skuString)
putString(PURCHASE_ERROR, paywallEvent.purchaseError ?: "")
putArray(PURCHASES, purchasesArray)
putString(CAMPAIGN_NAME, paywallEvent.campaignName ?: "")
Expand All @@ -175,6 +173,17 @@ class NamiCampaignManagerBridgeModule(reactContext: ReactApplicationContext) :
putString(DEEP_LINK_URL, paywallEvent.deeplinkUrl ?: "")
}

if (paywallEvent.sku != null) {
val skuMap =
Arguments.createMap().apply {
putString("id", paywallEvent.sku?.id ?: "")
putString("skuId", paywallEvent.sku?.skuId ?: "")
putString("name", paywallEvent.sku?.name ?: "")
putString("name", paywallEvent.sku?.type ?: "unknown")
}
resultMap.putMap(SKU, skuMap)
}

if (paywallEvent.componentChange != null) {
val componentChangeMap =
Arguments.createMap().apply {
Expand Down
11 changes: 10 additions & 1 deletion ios/NamiCampaignManagerBridge.swift
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,15 @@ class RNNamiCampaignManager: RCTEventEmitter {

let dictionaries = paywallEvent.purchases.map { purchase in RNNamiPurchaseManager.purchaseToPurchaseDict(purchase) }

var skuDict: [String: Any?] = [:]

if let sku = paywallEvent.sku {
skuDict["id"] = sku.id
skuDict["name"] = sku.name
skuDict["skuId"] = sku.skuId
skuDict["type"] = sku.type
}

var componentChange: [String: Any?] = [:]

if let eventComponentChange = paywallEvent.componentChange {
Expand Down Expand Up @@ -137,7 +146,7 @@ class RNNamiCampaignManager: RCTEventEmitter {
"segmentId": paywallEvent.segmentId,
"externalSegmentId": paywallEvent.externalSegmentId,
"action": actionString,
"skuId": paywallEvent.sku?.skuId,
"sku": skuDict,
"purchaseError": errorSting,
"purchases": dictionaries,
"deeplinkUrl": paywallEvent.deeplinkUrl,
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-nami-sdk",
"version": "3.2.2-3",
"version": "3.2.2-4",
"description": "React Native Module for Nami - Easy subscriptions & in-app purchases, with powerful built-in paywalls and A/B testing.",
"main": "index.ts",
"types": "index.d.ts",
Expand Down
Loading