Skip to content

Commit

Permalink
Update the generated deepcopy code for ClusterRoleOverride
Browse files Browse the repository at this point in the history
The lastest version (v0.13.0) of controller-gen crashes when generating
CRDs: kubernetes-sigs/controller-tools#851.
A newer version hasn't been released yet.

Before the new version is available, we use the HEAD on the master
branch as a temporary workaround.
  • Loading branch information
nan-yu committed Nov 7, 2023
1 parent aff5b90 commit 976a375
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 3 deletions.
3 changes: 2 additions & 1 deletion Makefile.reconcilermanager
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ configsync-crds: install-controller-gen "$(KUSTOMIZE)" "$(GOBIN)/addlicense"
.PHONY: install-controller-gen
# install controller-gen from source
install-controller-gen:
go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.13.0
# TODO: use a fixed version instead of master when https://github.com/kubernetes-sigs/controller-tools/issues/851 is fixed.
go install sigs.k8s.io/controller-tools/cmd/controller-gen@master

.PHONY: generate-in-docker
# Run make generate-in-docker in the docker buildenv container
Expand Down
2 changes: 1 addition & 1 deletion manifests/reposync-crd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.13.0
controller-gen.kubebuilder.io/version: v0.13.1-0.20231106142007-a28b9003e012
labels:
configmanagement.gke.io/arch: csmr
configmanagement.gke.io/system: "true"
Expand Down
2 changes: 1 addition & 1 deletion manifests/rootsync-crd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.13.0
controller-gen.kubebuilder.io/version: v0.13.1-0.20231106142007-a28b9003e012
labels:
configmanagement.gke.io/arch: csmr
configmanagement.gke.io/system: "true"
Expand Down
16 changes: 16 additions & 0 deletions pkg/api/configsync/v1beta1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 976a375

Please sign in to comment.