Merge pull request #388 from nanobox-io/hotfix/missing-boxfile

Check for a boxfile when an environment is being created

commands/destroy.go

@@ -36,6 +36,7 @@ func destroyFunc(ccmd *cobra.Command, args []string) {
 		return
 	}
 
+
 	if len(args) == 0 {
 		display.CommandErr(env.Destroy(envModel))	
 	}

processors/env/setup.go

@@ -4,22 +4,31 @@ import (
 	"fmt"
 
 	"github.com/jcelliott/lumber"
+	"github.com/nanobox-io/nanobox-boxfile"
 
 	"github.com/nanobox-io/nanobox/models"
 	"github.com/nanobox-io/nanobox/processors/provider"
 	"github.com/nanobox-io/nanobox/util"
+	"github.com/nanobox-io/nanobox/util/config"
 	"github.com/nanobox-io/nanobox/util/display"
 	util_provider "github.com/nanobox-io/nanobox/util/provider"
 )
 
 // Setup sets up the provider and the env mounts
 func Setup(envModel *models.Env) error {
 
+	// if there is no boxfile display a message and end
+	if box := boxfile.NewFromPath(config.Boxfile()); !box.Valid {
+		display.MissingBoxfile()
+		return util.ErrorfQuiet("missing or invalid boxfile")
+	}
+
 	// init docker client
 	if err := provider.Init(); err != nil {
 		return util.ErrorAppend(err, "failed to init docker client")
 	}
 
+
 	// ensure the envModel data has been generated
 	if err := envModel.Generate(); err != nil {
 		lumber.Error("env:Setup:models:Env:Generate()")

util/display/messages.go

@@ -230,3 +230,15 @@ We could not connect as the gonano user but we were able to
 fall back to the default user
 `, TaskComplete))
 }
+
+func MissingBoxfile() {
+	os.Stderr.WriteString(fmt.Sprintf(`
+--------------------------------------------------------------------------------
+MISSING BOXFILE.YML
+Nanobox is looking for a boxfile.yml config file. You might want to 
+check out our getting-started guide on configuring your app:
+
+https://guides.nanobox.io/
+--------------------------------------------------------------------------------
+`))	
+}

util/provider/dockermachine.go

@@ -8,6 +8,7 @@ import (
 	"os"
 	"os/exec"
 	// "path/filepath"
+	"io"
 	"regexp"
 	"runtime"
 	"strings"
@@ -143,14 +144,18 @@ func (machine DockerMachine) Create() error {
 
 	process := exec.Command(cmd[0], cmd[1:]...)
 
-	process.Stdout = display.NewStreamer("info")
-	process.Stderr = display.NewStreamer("info")
+	// lets try getting the extra bytes from creating
+	fullBuffer := &bytes.Buffer{}	
+	writer := io.MultiWriter(display.NewStreamer("info"), fullBuffer)
+
+	process.Stdout = writer
+	process.Stderr = writer
 
 	display.StartTask("Launching VM")
 
 	if err := process.Run(); err != nil {
 		display.ErrorTask()
-		return util.Error(err)
+		return util.Errorf("%s: %s", fullBuffer.String(), err)
 	}
 
 	display.StopTask()