Allow either username or email address for login #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhunsaker
added a commit
that referenced
this pull request
Sep 6, 2017
#565 introduced a looping Auth, because the path used to auth against was updated, but the path used to verify that the _current_ request isn't an Auth request was still using the outdated version. So `odin.doRequest()` never realized the request being made was an Auth request, which caused it to initiate a new Auth request of its own to get the creds with which to make the _actual_ request. Which it didn't realize already was an Auth request. And so on. This commit updates the check to use the correct path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #557