Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add System.Diagnostics.Debug class #106

Merged
merged 1 commit into from
May 29, 2020
Merged

Add System.Diagnostics.Debug class #106

merged 1 commit into from
May 29, 2020

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented May 29, 2020 •
edited
Loading

Description

  • Moved from Runtime.Native.
  • Bumped version to 1.7.3-preview.
  • Bumped AssemblyNativeVersion to 100.4.10.0.

Motivation and Context

  • Improve usability. Debug.WriteLine is commonly used and with the previous approach required to add Runtime.Native assembly just because of it. Didn't make much sense.
    Impact on size is null as the class was moved from one class to the other.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

@josesimoes
Add System.Diagnostics.Debug class
843a583 
- Moved from Runtime.Native.
- Bumped version to 1.7.3-preview.
- Bumped AssemblyNativeVersion to 100.4.10.0.

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@nfbot
Copy link
Member

nfbot commented May 29, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes mentioned this pull request May 29, 2020
Merged
10 tasks
@sonarcloud
Copy link

sonarcloud bot commented May 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (1.8.0_222) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@josesimoes josesimoes mentioned this pull request May 29, 2020
Merged
10 tasks
@josesimoes josesimoes merged commit d0ae80d into nanoframework:develop May 29, 2020
@josesimoes josesimoes deleted the add-system-diagnostics branch May 29, 2020 16:28
@josesimoes
Copy link
Member Author

@nfbot startrelease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Breaking-Change CI: Publish Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot