Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TryParse #168

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Add TryParse #168

merged 1 commit into from
Jan 19, 2022

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Jan 19, 2022

Description

  • Implement method in the various classes.
  • Remove checks for null params in all Parse calls (this check is now carried in native).
  • Rework existing NativeToInt64 and NativeToDouble with param to set throwing exception and to return conversion success/failure.
  • Add Unit Tests and some rework on the existing ones where these were added.
  • Fix documentation and update formatting to follow code style.
  • Bump AssemblyNativeVersion 100.5.0.15.

Wit the overall changes (new feature+rework) this increases the PE size roughly ~200 bytes which seems cheap for the added value.

(temporarily disable float and double infinity tests)

Motivation and Context

  • Implements a feature highly requested by the community..

How Has This Been Tested?

  • Adding new units tests and improving the existing ones for Parse().

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Implement method in the various classes.
- Remove checks for null params in all Parse calls (this check is now carried in native).
- Rework existing NativeToInt64 and NativeToDouble with param to set throwing exception and to return conversion success/failure.
- Add Unit Tests and some rework on the existing ones where these were added.
- Fix documentation and update formatting to follow code style.
- Bump AssemblyNativeVersion 100.5.0.15.

(temporarily disable float and double infinity tests)
@josesimoes
Copy link
Member Author

Unit Tests will fail because of the mismatch in WIN32 nanoCLR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants