Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi parameter constructors in attributes #177

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

josesimoes
Copy link
Member

Description

  • Update the code to deal properly with the updated structure coming from native.

Motivation and Context

  • Allows using attributes with multi parameters constructors.

How Has This Been Tested?

  • Running unit tests on MDP.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

- Update the code to deal properly with the updated structure coming from native.
@josesimoes josesimoes added the ⚠️ DO NOT MERGE ⚠️ This is not to be merged. In doubt check with the person that put the label. label Mar 11, 2022
@josesimoes
Copy link
Member Author

Build will fail on unit test because WIN32 nanoCLR is not up to date.

@josesimoes josesimoes removed the ⚠️ DO NOT MERGE ⚠️ This is not to be merged. In doubt check with the person that put the label. label Mar 14, 2022
@josesimoes josesimoes merged commit 8147509 into develop Mar 14, 2022
@josesimoes josesimoes deleted the improve-GetCustomAttributesInternal branch March 14, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants